OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Pickup Java version from .properties in OpenSearch gradle check

Open dblock opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe

Coming from https://github.com/opensearch-project/opensearch-build/issues/74#issuecomment-956496829. Use different JDKs depending on which branch of OpenSearch is being built.

Describe the solution you'd like

OpenSearch has CI defined in a private freestyle project that runs gradle check on OpenSearch#main, branches and PRs. It will get extracted into a Jenkinsfile that is committed to the OpenSearch repo in https://github.com/opensearch-project/opensearch-build/issues/851.

It will then needs to pickup the JDK version to use from https://github.com/opensearch-project/OpenSearch/blob/main/.ci/java-versions.properties#L16.

Describe alternatives you've considered

No response

Additional context

No response

dblock avatar Nov 17 '21 16:11 dblock

Transferring this issue to https://github.com/opensearch-project/OpenSearch/ repo as this enhancement will be addressed as part of Gradle check migration process.

bbarani avatar Mar 07 '22 19:03 bbarani

@bbarani is this already addressed?

minalsha avatar Aug 02 '22 18:08 minalsha

@peterzhuamazon would know - show us where we get the java version in gradle checks?

dblock avatar Aug 05 '22 23:08 dblock

@peterzhuamazon would know - show us where we get the java version in gradle checks?

You can improve it by getting it from versions.properties, and sent from webhook to Jenkins runs. https://github.com/opensearch-project/opensearch-build/blob/main/vars/runGradleCheck.groovy#L36-L42

peterzhuamazon avatar Aug 05 '22 23:08 peterzhuamazon

Thanks @peterzhuamazon - @minalsha this is not done, care to queue it up?

dblock avatar Aug 11 '22 17:08 dblock

@peterzhuamazon @dblock since build infra is open now, I could take it (if there are no objections)

reta avatar Aug 16 '22 14:08 reta