OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Activate Detect Breaking Changes Github Action since we have 3.0.0 baseline

Open reta opened this issue 5 months ago • 2 comments

Description

Activate Detect Breaking Changes Github Action since we have 3.0.0 baseline

Related Issues

N/A

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

reta avatar Jun 11 '25 23:06 reta

@andrross @msfroh @cwperks tons of breaking changes already ....

reta avatar Jun 12 '25 00:06 reta

:x: Gradle check result for d340204876bce811ae0b483e237d2f7343bc194a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 16 '25 03:06 github-actions[bot]

:x: Gradle check result for 6099c70e5b2bc6fbec1684675a75d5b855dbdb2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 16 '25 13:06 github-actions[bot]

Related issue: #18202

andrross avatar Jun 16 '25 21:06 andrross

:x: Gradle check result for 6099c70e5b2bc6fbec1684675a75d5b855dbdb2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 16 '25 21:06 github-actions[bot]

:white_check_mark: Gradle check result for 6099c70e5b2bc6fbec1684675a75d5b855dbdb2e: SUCCESS

github-actions[bot] avatar Jun 16 '25 23:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.64%. Comparing base (3078649) to head (6099c70). Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
.../org/opensearch/search/internal/SearchContext.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #18501   +/-   ##
=========================================
  Coverage     72.64%   72.64%           
+ Complexity    68070    68038   -32     
=========================================
  Files          5537     5537           
  Lines        313404   313382   -22     
  Branches      45476    45472    -4     
=========================================
- Hits         227658   227647   -11     
+ Misses        67241    67233    -8     
+ Partials      18505    18502    -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 16 '25 23:06 codecov[bot]

Hi @reta Any thoughts on how can i resolve the breaking changes in this PR: https://github.com/opensearch-project/OpenSearch/pull/18467.

It is failing with

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':server:japicmp'.
> A failure occurred while executing me.champeau.gradle.japicmp.JApiCmpWorkAction
   > Detected binary changes.
         - current: opensearch-3.1.0-SNAPSHOT.jar
         - baseline: opensearch-3.0.0.jar.

skumawat2025 avatar Jun 17 '25 16:06 skumawat2025