remaining changes from 14912

[beanuwave]

Description

remaining changes from original PR#14912

Related Issues

Resolves RFC

Check List

• [x] Functionality includes testing.
• [ ] API changes companion pull request created, if applicable.
• [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions[bot]]

:x: Gradle check result for 9b5da5c5d0aa3468057283fe77531292aa313969: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 986dce7737583fbcce88a8a489addcf9148cf413: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[terryquigleysas]

I'd like to raise a general point here to keep in mind with this development, especially as instructions will be required for Java setups other than the bundled version. The Red Hat JDK 21, for example, has a default of fips.keystore.type: PKCS12 - see https://docs.redhat.com/en/documentation/red_hat_build_of_openjdk/21/html/configuring_red_hat_build_of_openjdk_21_on_rhel_with_fips/fips_settings#fips_settings .

We'd like to ensure that code checks aren't so stringent as to prevent this setup from working.

[github-actions[bot]]

:x: Gradle check result for 939e6b580bcaa5fa1ff1a43982271ea722787183: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 11da6679457dcf40cf6598895323c9126a0ecc05: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 9a387a4bad8b6488d2c41469bf84e6f993365621: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 4e0af75706806a3e498bb1df68787af1d6eae67f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 9efd8380fc45b1c293dac80bea591c05f946916f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 4fc6b4005cfc5db0e06ad06c03e8371fecb22cb2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 0139eaa832cb9375abffc4d42eda96a979d973c6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for f52e7206d5682123d0edb7a55fe72ec08419eca8: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[beanuwave]

The Red Hat JDK 21, for example, has a default of fips.keystore.type: PKCS12

@terryquigleysas Thank you for pointing out those limitations.

We'd like to ensure that code checks aren't so stringent as to prevent this setup from working.

We rely on SunPKCS12 provider to load the JVM's default truststore. In case of OpenJKD the default type is the same as RHEL's - so nothing changes for us.

[terryquigleysas]

The Red Hat JDK 21, for example, has a default of fips.keystore.type: PKCS12

@terryquigleysas Thank you for pointing out those limitations.

We'd like to ensure that code checks aren't so stringent as to prevent this setup from working.

We rely on SunPKCS12 provider to load the JVM's default truststore. In case of OpenJKD the default type is the same as RHEL's - so nothing changes for us.

Good news. Thank you for the reply. Much appreciated!

[github-actions[bot]]

:x: Gradle check result for cb7949d7845a658389c8fe29a037e43bb0fc4723: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 0680de8a6b7c4fce588500e28bd4e94170ab6ccb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 732e412420e21ddc26bfcdce684163e37289192c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for 6164088242c449dc88bac8eb04bd9a92c80c24a5: SUCCESS

[codecov[bot]]

Codecov Report

:x: Patch coverage is 58.11966% with 49 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.18%. Comparing base (d5aa830) to head (f3f0880). :warning: Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
.../opensearch/cloud/gce/GceInstancesServiceImpl.java	7.69%	12 Missing :warning:
...n/java/org/opensearch/common/ssl/KeyStoreUtil.java	68.96%	5 Missing and 4 partials :warning:
...sitories/gcs/GoogleCloudStorageClientSettings.java	69.23%	4 Missing and 4 partials :warning:
...g/opensearch/common/ssl/TrustEverythingConfig.java	0.00%	3 Missing and 1 partial :warning:
...ch/repositories/gcs/GoogleCloudStorageService.java	77.77%	3 Missing and 1 partial :warning:
...rg/opensearch/common/settings/KeyStoreWrapper.java	50.00%	3 Missing and 1 partial :warning:
...g/opensearch/common/ssl/DefaultJdkTrustConfig.java	0.00%	2 Missing and 1 partial :warning:
...va/org/opensearch/common/ssl/SslConfiguration.java	0.00%	2 Missing and 1 partial :warning:
.../opensearch/common/ssl/SslConfigurationLoader.java	80.00%	1 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18491      +/-   ##
============================================
- Coverage     73.23%   73.18%   -0.06%     
- Complexity    71544    71566      +22     
============================================
  Files          5786     5787       +1     
  Lines        327013   327109      +96     
  Branches      47284    47295      +11     
============================================
- Hits         239498   239389     -109     
- Misses        68245    68510     +265     
+ Partials      19270    19210      -60     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions[bot]]

:x: Gradle check result for fea87d06913e15d8de47bfc12c14c6424f8602ae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for c3002d8d00c52db82ba409c047e078025967df80: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for ff0e10832b8ef49670db1cc3c6cb43656e630906:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for ff0e10832b8ef49670db1cc3c6cb43656e630906: SUCCESS

[opensearch-trigger-bot[bot]]

This PR is stalled because it has been open for 30 days with no activity.

[github-actions[bot]]

:x: Gradle check result for 73226717556e35bff7442b0016436337f38ad7a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for df8c0fa3c3935afc3f4b2a32d4fff199a343570e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:grey_exclamation: Gradle check result for 4f0bed715f57ca12018981929f4d9970038e8838: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions[bot]]

:x: Gradle check result for 0da4c6da0bbf3ce23450d7a299987cf805990b75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for fcc6a0520755bea4e3fcd7aa98d510d65c120ca5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for bbf73cff6b97cc1642686a667d56a61005cbadac: SUCCESS

[beanuwave]

@cwperks @reta I believe this PR is ready for review - can you take a look please?