OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Add NodeResourceUsageStats to ClusterInfo

Open abhita opened this issue 6 months ago • 2 comments

Description

Add NodeResourceUsageStats to ClusterInfo to make Node-level usage stats available to all nodes

Related Issues

Resolves #[[Writable Warm] Adding Support For NodeResourceUsageStats in ClusterInfo]

Check List

  • [x] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

abhita avatar Jun 10 '25 04:06 abhita

:x: Gradle check result for 12c0e4d616be2a8a12100f29d9ca08aaf6ba416e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 10 '25 05:06 github-actions[bot]

:x: Gradle check result for a1af9eb657d85350704f00b262228a63ec3c2049: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 10 '25 07:06 github-actions[bot]

:x: Gradle check result for e68568df8f2c2df5d235a94e5dc3d3e1326201ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 17 '25 11:06 github-actions[bot]

:x: Gradle check result for 7de9472fdb24ab573ea36574b6c8cd1c581a6335: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 17 '25 13:06 github-actions[bot]

:x: Gradle check result for 6eb534acbeed0fcca55841ef3d6a8a9172b6a25e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 17 '25 14:06 github-actions[bot]

:x: Gradle check result for 850331461d4f1a788c7d7cf82062ad11c6bd0d28: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 17 '25 18:06 github-actions[bot]

:x: Gradle check result for b84c9187e6f2a3d8e2e34892b86a2d2468061365: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 18 '25 05:06 github-actions[bot]

:white_check_mark: Gradle check result for 72a73852e782dff3510a4c66ec350e7aa6cb8ba3: SUCCESS

github-actions[bot] avatar Jun 18 '25 20:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 51.11111% with 22 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (e2deff6) to head (3933318). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/opensearch/node/NodeResourceUsageStats.java 0.00% 9 Missing :warning:
...opensearch/cluster/InternalClusterInfoService.java 68.18% 4 Missing and 3 partials :warning:
.../main/java/org/opensearch/cluster/ClusterInfo.java 61.53% 2 Missing and 3 partials :warning:
...a/org/opensearch/node/NodesResourceUsageStats.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18480      +/-   ##
============================================
+ Coverage     72.69%   72.75%   +0.05%     
- Complexity    68159    68182      +23     
============================================
  Files          5541     5541              
  Lines        313391   313426      +35     
  Branches      45474    45479       +5     
============================================
+ Hits         227829   228030     +201     
+ Misses        67071    66850     -221     
- Partials      18491    18546      +55     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 18 '25 20:06 codecov[bot]

:white_check_mark: Gradle check result for 28c13e34f2e4cea1f8be10566e3a23f554a9607c: SUCCESS

github-actions[bot] avatar Jun 19 '25 07:06 github-actions[bot]

:x: Gradle check result for ad45f2b3fd5c654c4fd895cd0c350c27eda2049d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 19 '25 07:06 github-actions[bot]

:x: Gradle check result for b9c94b9ba2a13dc1d19f7e5bd97386cde0bd98ea:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 19 '25 10:06 github-actions[bot]

:white_check_mark: Gradle check result for 8f98f76fe7481b5455cef91cfa59bddafeab663d: SUCCESS

github-actions[bot] avatar Jun 19 '25 12:06 github-actions[bot]

:x: Gradle check result for bce898a1ccb44b4666e7227fbb9d50cc6522cc65: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 19 '25 13:06 github-actions[bot]

:white_check_mark: Gradle check result for 7f6fa7357428545faee2a0882b089e8e97b18645: SUCCESS

github-actions[bot] avatar Jun 19 '25 15:06 github-actions[bot]

:grey_exclamation: Gradle check result for 3933318167525d6f3460c3897781406c4b9986dc: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Jun 23 '25 09:06 github-actions[bot]

@gbbafna @abhita I believe the test failure in the last gradle check run in this PR comment link is caused by this change. That test failure is now impacting other PRs.

I think the root cause is that the onOrAfter checks in this PR need to be V_3_2_0 instead of V_3_1_0 since this change does not exist in version 3.1.

andrross avatar Jun 25 '25 17:06 andrross