OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

[Star tree] Handle delete cases for star tree

Open bharath-techie opened this issue 4 months ago • 2 comments

Description

When there are delete operations in the index, there are segments where SegmentDocValuesProducers is present which contains List<DocValuesProducers> contrary to segments in index where no deletes are present.

So one change is to pick DocValuesProducer in the list where StarTreeValues is present - usually I see that one field is present only in one of the DocValuesProducer - even SegmentDocValuesProducer has a map of FieldInfo to DocValuesProducer which confirms the same.

Secondly there are issues because of segmentSuffix missing in the custom write state and read state. So have added the same.

Also including fixes from https://github.com/opensearch-project/OpenSearch/pull/16124

Related Issues

Resolves https://github.com/opensearch-project/OpenSearch/issues/16381

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

bharath-techie avatar Oct 18 '24 10:10 bharath-techie