OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Explicitly set the include discovery nodes flag for reload secure setting request.

Open SwethaGuptha opened this issue 1 year ago • 4 comments

Description

Backport https://github.com/opensearch-project/OpenSearch/commit/620db0a64950cbd6a38642f0be1f592060dac1ee from https://github.com/opensearch-project/OpenSearch/pull/15972.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

SwethaGuptha avatar Sep 19 '24 14:09 SwethaGuptha

:white_check_mark: Gradle check result for 5b3945c8b4eabd4d823e3b0ba23ac1988cff2421: SUCCESS

github-actions[bot] avatar Sep 19 '24 14:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (5c586ef) to head (5b3945c). Report is 3 commits behind head on 2.17.

Files with missing lines Patch % Lines
.../node/reload/NodesReloadSecureSettingsRequest.java 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15998      +/-   ##
============================================
+ Coverage     71.64%   71.65%   +0.01%     
+ Complexity    64580    64524      -56     
============================================
  Files          5264     5264              
  Lines        302101   302102       +1     
  Branches      43976    43976              
============================================
+ Hits         216427   216466      +39     
+ Misses        67658    67483     -175     
- Partials      18016    18153     +137     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Sep 19 '24 14:09 codecov[bot]

This PR is stalled because it has been open for 30 days with no activity.

@SwethaGuptha This is a backport to 2.17 which is already released. Does it still need to be reviewed/approved?

dbwiddis avatar Oct 19 '24 17:10 dbwiddis

This PR is stalled because it has been open for 30 days with no activity.