Fix: visit of inner query for FunctionScoreQueryBuilder

[jdnvn]

Description

Similar to https://github.com/opensearch-project/OpenSearch/pull/14739, but implements the visit method in FunctionScoreQueryBuilder to allow subqueries to be processed properly.

Related Issues

Resolves #15403 Similar to https://github.com/opensearch-project/OpenSearch/issues/15034

Check List

• [x] Functionality includes testing.
• [x] API changes companion pull request created, if applicable.
• [x] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions[bot]]

:white_check_mark: Gradle check result for 7bac68864664ee525656a4aaff49b1fe2cc5486a: SUCCESS

[github-actions[bot]]

:grey_exclamation: Gradle check result for d8e8390bdddcee2b734c9f7783cc670d2a7a8145: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (6152afe) to head (3258eea). Report is 16 commits behind head on main.

Files	Patch %	Lines
...query/functionscore/FunctionScoreQueryBuilder.java	75.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15404      +/-   ##
============================================
- Coverage     71.95%   71.92%   -0.03%     
+ Complexity    63254    63229      -25     
============================================
  Files          5224     5224              
  Lines        296079   296083       +4     
  Branches      42763    42764       +1     
============================================
- Hits         213030   212946      -84     
- Misses        65550    65671     +121     
+ Partials      17499    17466      -33     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[yuye-aws]

Hi @gaobinlong and @zhichao-aws ! Can you help review this PR?

[zhichao-aws]

I'd recommend @vibrantvarun take a look at this PR, thanks!

[yuye-aws]

Hi @jdnvn ! The DCO checks have failed. Can you follow the guide https://github.com/opensearch-project/OpenSearch/pull/15404/checks?check_run_id=29224905792 to fix this?

[github-actions[bot]]

:x: Gradle check result for 3258eea64c1fddd53f14b33b81d521e61e8b3e85: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for 3258eea64c1fddd53f14b33b81d521e61e8b3e85: SUCCESS

[jdnvn]

@yuye-aws @zhichao-aws @vibrantvarun hello, I updated the PR and CI is green now. Mind taking another look?

[github-actions[bot]]

:x: Gradle check result for 39b50b9fc10b5e78217e9710d7032e43df74d8dd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 378b9842d41030b6317f0624c02f5633918e522d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[yuye-aws]

@jdnvn Can you fix the DCO and gradle check?

[opensearch-trigger-bot[bot]]

This PR is stalled because it has been open for 30 days with no activity.

[yuye-aws]

@msfroh Can you rerun the gradle checks?

[msfroh]

@jdnvn It looks like one of your commits is unsigned. That's breaking the DCO check.

You can git rebase -i to interactively rebase, say pick for the first commit and squash for the rest to collapse down to one commit. Then either keep ones of the sign-offs or do git commit --amend -s to sign off the single commit. Then you can git push -f to your fork.

[msfroh]

Since we've had at least one release since this PR was opened, we'll need to rebase it onto the latest main branch to pick up new version constants. I can take care of that during my business hours (US PDT) tomorrow.

[opensearch-trigger-bot[bot]]

This PR is stalled because it has been open for 30 days with no activity.

[kodieg]

Will this change make into the next release?

[dblock]

Will this change make into the next release?

Someone needs to rebase this PR against main and iterate it to green. Looks like @jdnvn is unfortunately MIA, care to help?

[kodieg]

Opened a new PR https://github.com/opensearch-project/OpenSearch/pull/16776

[kodieg]

@dblock I rebased today and it seems that all tests has passed. https://github.com/opensearch-project/OpenSearch/pull/16776

Should I do anything else?

[jdnvn]

Will this change make into the next release?

Someone needs to rebase this PR against main and iterate it to green. Looks like @jdnvn is unfortunately MIA, care to help?

@dblock I apologize for my lack of responsiveness, I have been caught up with work. I just fixed the PR, we should be good to go once CI passes!

[github-actions[bot]]

:x: Gradle check result for 4bf593805f0a5452612f31fb9d80ad7cc1fdbfb9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 571931888cb7e9f4f5019da2dcef2b6f98cd1973: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for b9e9a20971265e3e2f64852feb030785c50878d0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[jdnvn]

@dblock @dbwiddis @vibrantvarun are these tests flaky? It doesn't look like they are related to the change

 - org.opensearch.action.admin.cluster.tasks.PendingTasksBlocksIT.testPendingTasksWithClusterNotRecoveredBlock
 - org.opensearch.action.admin.cluster.tasks.PendingTasksBlocksIT.testPendingTasksWithClusterReadOnlyBlock
 - org.opensearch.remotemigration.RemotePrimaryRelocationIT.testMixedModeRelocation_FailInFinalize
 - org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode