OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

[Streaming Indexing] Introduce bulk HTTP API streaming flavor

Open reta opened this issue 1 year ago • 10 comments

Description

Introduce bulk HTTP API streaming flavor

Related Issues

Closes https://github.com/opensearch-project/OpenSearch/issues/9070

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

reta avatar Aug 23 '24 15:08 reta

:x: Gradle check result for 0a25d483c133415fdf4dfc3da061e3d946fa9197: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 23 '24 15:08 github-actions[bot]

:x: Gradle check result for 503e05e03556f28de3928459a5a00fd01f31017a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 23 '24 16:08 github-actions[bot]

:x: Gradle check result for b8d22742c8de8d668a737dcc345e9c1b75de3cac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 27 '24 12:08 github-actions[bot]

:x: Gradle check result for e4f4a0b333224f1d9e2a4ad9a7a9d3a71450a663: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 27 '24 13:08 github-actions[bot]

:white_check_mark: Gradle check result for 20f72eb1682e6ca7c6553c605c7760ba7f7f9ade: SUCCESS

github-actions[bot] avatar Aug 27 '24 14:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 12.00000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (23cba28) to head (62b27d2). Report is 1 commits behind head on main.

Files Patch % Lines
...rc/main/java/org/opensearch/client/RestClient.java 0.00% 22 Missing :warning:
.../rest/action/document/RestBulkStreamingAction.java 12.00% 20 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15381      +/-   ##
============================================
- Coverage     71.91%   71.90%   -0.02%     
- Complexity    63311    63326      +15     
============================================
  Files          5225     5225              
  Lines        296350   296389      +39     
  Branches      42809    42818       +9     
============================================
- Hits         213119   213113       -6     
- Misses        65743    65811      +68     
+ Partials      17488    17465      -23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '24 14:08 codecov[bot]

:grey_exclamation: Gradle check result for 4ea5f38e406d6155454e408499b3821d1c814425: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 27 '24 19:08 github-actions[bot]

:white_check_mark: Gradle check result for 123230959b85ceef44f43ff06a97252555024f1d: SUCCESS

github-actions[bot] avatar Aug 27 '24 20:08 github-actions[bot]

:white_check_mark: Gradle check result for 5a351ca941488028376227a6f7fbc02131b3a6a0: SUCCESS

github-actions[bot] avatar Aug 27 '24 20:08 github-actions[bot]

:grey_exclamation: Gradle check result for b833dce56ca626ac66d3442eb0efc29dd1313909: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=search.aggregation/20_terms/string profiler via global ordinals}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 27 '24 21:08 github-actions[bot]

:x: Gradle check result for 5b3087aec41ce2070f10214e555a2c6d78533e4d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 28 '24 13:08 github-actions[bot]

:white_check_mark: Gradle check result for 9c1aad3af18e7d8f353022c81080219064097c2e: SUCCESS

github-actions[bot] avatar Aug 28 '24 14:08 github-actions[bot]

@andrross thanks a mill for approving, conflicts resolved + more tests added, could you please reapprove? thank you!

reta avatar Aug 28 '24 14:08 reta

:grey_exclamation: Gradle check result for 62b27d20a8a3c2da36b378b618ff8da55668748e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 28 '24 15:08 github-actions[bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15381-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8d17c8d87e67db8924ed66ab0128f0bdc6aff274
# Push it to GitHub
git push --set-upstream origin backport/backport-15381-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15381-to-2.x.