OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Add support to cluster stats API for enabling/disabling mapping_stats…

Open SwethaGuptha opened this issue 1 year ago • 8 comments

… and analysis_stats at request level.

Description

Continuing on https://github.com/opensearch-project/OpenSearch/pull/14447 to make analysis_stats and mapping_stats information optional in _cluster/stats API but limiting the scope to request level only. Two request params namely include_mapping_stats and include_analysis_stats has been introduced to enable/disable these stats info from the cluster stats API. By default these stats info will be part of the API response.

REST request formats to exclude the information for

  • analysis_stats - localhost:9200/_cluster/stats?include_mapping_stats=false
  • mapping_stats - localhost:9200/_cluster/stats?include_analysis_stats=false
  • analysis_stats and mapping_stats - localhost:9200/_cluster/stats?include_analysis_stats=false&include_mapping_stats=false

Related Issues

Resolves #[Issue number to be closed when this PR is merged] https://github.com/opensearch-project/OpenSearch/pull/14447

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

SwethaGuptha avatar Aug 23 '24 05:08 SwethaGuptha

:x: Gradle check result for 839fbe020ee378441818750255714867922d81cd: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 23 '24 05:08 github-actions[bot]

:grey_exclamation: Gradle check result for 79d1b90ff13d9106f08080e00be9a9a60fcc867b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationMultiSearchDuringFetchPhase

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 23 '24 06:08 github-actions[bot]

:white_check_mark: Gradle check result for 8f4e25f9e1e6c28ef64e828f5e3fb3a0a12f024d: SUCCESS

github-actions[bot] avatar Aug 25 '24 16:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (ed65482) to head (65b6b00). Report is 354 commits behind head on main.

Files with missing lines Patch % Lines
...tion/admin/cluster/stats/ClusterStatsResponse.java 66.66% 1 Missing and 4 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15377      +/-   ##
============================================
- Coverage     71.96%   71.82%   -0.14%     
+ Complexity    63304    63205      -99     
============================================
  Files          5219     5219              
  Lines        296033   296062      +29     
  Branches      42756    42760       +4     
============================================
- Hits         213026   212654     -372     
- Misses        65520    65970     +450     
+ Partials      17487    17438      -49     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 25 '24 16:08 codecov[bot]

:x: Gradle check result for 5d8aaccd9a77fecb1a9c5842f7a8113e3eebb623: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 27 '24 19:08 github-actions[bot]

:x: Gradle check result for 849c8400f79c8e3696760fd0ccedf953474bb9c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 28 '24 08:08 github-actions[bot]

:x: Gradle check result for edc3eaec0c6e38fcabbe6810ffc59d3242c881c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 28 '24 09:08 github-actions[bot]

❌ Gradle check result for edc3eae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test https://github.com/opensearch-project/OpenSearch/pull/15204

SwethaGuptha avatar Aug 28 '24 10:08 SwethaGuptha

:grey_exclamation: Gradle check result for 65b6b00eddb4bbff8be4ef88c5982fbad22d30e0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 28 '24 13:08 github-actions[bot]

This PR is stalled because it has been open for 30 days with no activity.

This PR is stalled because it has been open for 30 days with no activity.