OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Create Index using context

Open mgodwan opened this issue 1 year ago • 18 comments

Description

In 2.16, we enabled functionality to use context to create index templates. This goes a step ahead, and allows to create index using the context directly specified in index creation.

Related Issues

Resolves https://github.com/opensearch-project/OpenSearch/issues/12683

Check List

  • [x] Functionality includes testing.
  • [x] API changes companion pull request created, if applicable.
  • [x] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

mgodwan avatar Aug 19 '24 04:08 mgodwan

:x: Gradle check result for a1b5efadb914757228a329dfede9e1f0c0f3af13: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 19 '24 04:08 github-actions[bot]

:x: Gradle check result for e2363aa88ad70c2a5ec416217b14f5e20518c805: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 09:08 github-actions[bot]

:x: Gradle check result for 600acc133e7160ebe8211153fccbe162fdb5273a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]

:x: Gradle check result for 1c53a98195173ba7853fa5bfbcbd82019be6e837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]

:x: Gradle check result for 1cc4f20866c4c89a99cfc00e5d73b01f5484306c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]

:x: Gradle check result for 79352e13777352d58a62401e795cfd9fd2ba50f5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]

:x: Gradle check result for 7884e1d8d3526be5a605bfc01fc83e72c58d0dee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]

:x: Gradle check result for dbc11bc147d2468ed40aba22acf64c878b2ba283: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]

:x: Gradle check result for 7c2914d670bd1ba7ffee7e9dc9fd0e560c1dd2c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 20:08 github-actions[bot]

:x: Gradle check result for 4e85e2878994f614c58c3022dea1327990a989a5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 20 '24 21:08 github-actions[bot]

:x: Gradle check result for 1b8fdf4d43328df28d9f07cfc54813fe52308a87: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 21 '24 06:08 github-actions[bot]

:x: Gradle check result for 6a6b51f3beb6ac7f34318b9cb0fb2a1f1a7f7e00: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 21 '24 06:08 github-actions[bot]

:x: Gradle check result for 2f9a2cdcb937040d5a5c8b15e93a10350d222a35: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 23 '24 16:08 github-actions[bot]

:white_check_mark: Gradle check result for 88246c999dedd58321163ddb6ee382597e4cdd7e: SUCCESS

github-actions[bot] avatar Aug 25 '24 10:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 72.43243% with 51 lines in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (57a597f) to head (f8455ea). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...luster/metadata/MetadataUpdateSettingsService.java 9.09% 8 Missing and 2 partials :warning:
...org/opensearch/cluster/metadata/IndexMetadata.java 68.00% 3 Missing and 5 partials :warning:
...rg/opensearch/client/indices/GetIndexResponse.java 50.00% 3 Missing and 3 partials :warning:
...ction/admin/indices/create/CreateIndexRequest.java 70.00% 4 Missing and 2 partials :warning:
...rch/action/admin/indices/get/GetIndexResponse.java 72.72% 1 Missing and 5 partials :warning:
...h/cluster/metadata/MetadataCreateIndexService.java 90.56% 2 Missing and 3 partials :warning:
...dmin/indices/create/CreateIndexRequestBuilder.java 0.00% 4 Missing :warning:
...ensearch/indices/InvalidIndexContextException.java 40.00% 3 Missing :warning:
.../java/org/opensearch/cluster/metadata/Context.java 50.00% 1 Missing and 1 partial :warning:
...ion/admin/indices/get/TransportGetIndexAction.java 91.66% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15290      +/-   ##
============================================
+ Coverage     71.96%   72.02%   +0.05%     
- Complexity    63584    63639      +55     
============================================
  Files          5246     5247       +1     
  Lines        297030   297189     +159     
  Branches      42909    42939      +30     
============================================
+ Hits         213766   214047     +281     
+ Misses        65764    65557     -207     
- Partials      17500    17585      +85     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 25 '24 10:08 codecov[bot]

:white_check_mark: Gradle check result for 2e0ab7c5fdc67824840af4840893de0ce498995d: SUCCESS

github-actions[bot] avatar Aug 25 '24 18:08 github-actions[bot]

:grey_exclamation: Gradle check result for d14f3ceb7012282bef269d4613a50dda67668f01: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 26 '24 06:08 github-actions[bot]

:grey_exclamation: Gradle check result for 6d3b1cb010050c52d5ed97c16400970a7ceb247c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/360_date_histogram/Date histogram aggregation w/ shared field range test}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 26 '24 09:08 github-actions[bot]

:x: Gradle check result for c860f7d7517b71ed660cbe8a00d9b225e347a278: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 29 '24 10:08 github-actions[bot]

Please don't forget to add context to https://github.com/opensearch-project/opensearch-api-specification.

dblock avatar Aug 29 '24 12:08 dblock

Please don't forget to add context to https://github.com/opensearch-project/opensearch-api-specification.

Yes, I'm making the changes for the same :)

mgodwan avatar Aug 29 '24 12:08 mgodwan

:grey_exclamation: Gradle check result for 247e2408bbdfc856ab55ceaa4ec7288b6a88ab3f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 29 '24 12:08 github-actions[bot]

:grey_exclamation: Gradle check result for 9bc165cba53518ab2ad22b704972b815ea97427e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 29 '24 12:08 github-actions[bot]

:grey_exclamation: Gradle check result for 58955b96e02187b530024ab78cd42b70eabebb28: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Aug 30 '24 08:08 github-actions[bot]

:white_check_mark: Gradle check result for f8455ea9982125ef139527ada0c5497b16897233: SUCCESS

github-actions[bot] avatar Aug 30 '24 10:08 github-actions[bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15290-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e3f8a38601efb0b8269e7099fa10adb7c8191505
# Push it to GitHub
git push --set-upstream origin backport/backport-15290-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15290-to-2.x.