Fix null values indexed as "null" strings in flat_object field

[kkewwei]

Signed-off-by: kkewwei [email protected]

Description

The pr soloves three cases:

• fix null value case, I have test too many cases about null value, all of the tests are passed.
• deduplication the value of fieldName, valueList, valueAndPathList, there is no need to store the duplicate values.
• fix infinite loop with null value (comment)

Related Issues

Resolves #13880

Check List

• [x] Functionality includes testing.
• [x] API changes companion pull request created, if applicable.
• [x] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions[bot]]

:x: Gradle check result for 53b80069d828b1a09d7b809d7e2c380beb616097: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 3a814c8ab7ef5c281fcbd4ab95b209903682a65e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 687dbfb9d37340837c146368b56f9a505143ebc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for c61403ef274800964bac18f2de024ac4321a7f13: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 67525ea5869b6231568998ef3f4b583a06a17f6b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 87febe3eda1f026ee1618d51b5c940ffd23f51a1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 03be17bb6682c708c6f093e59583dfdfae10b686: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

❌ Gradle check result for 03be17b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode #13600 RemoteMigrationIndexMetadataUpdateIT.testRemoteIndexPathFileExistsAfterMigration #13939

[kkewwei]

@msfroh, @mingshl, please have a look when you are free.

[github-actions[bot]]

:grey_exclamation: Gradle check result for a7b8d0199021ec86dfc59eec2b6255f7253e4bc7: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (2b84305) to head (53306f7). Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...ch/common/xcontent/JsonToStringXContentParser.java	60.60%	6 Missing and 7 partials :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14069      +/-   ##
============================================
+ Coverage     71.90%   71.92%   +0.01%     
- Complexity    63481    63490       +9     
============================================
  Files          5244     5244              
  Lines        296798   296819      +21     
  Branches      42852    42858       +6     
============================================
+ Hits         213414   213488      +74     
+ Misses        65917    65831      -86     
- Partials      17467    17500      +33     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[kkewwei]

❕ Gradle check result for a7b8d01: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

ClusterRerouteIT.testDelayWithALargeAmountOfShards #10558

[ankitkala]

@dhwanilpatel to take a look

[kkewwei]

@dhwanilpatel, please have a look when you are free.

[github-actions[bot]]

:x: Gradle check result for f4f3a859781bd0f14a3142341f7e97f612279f2d:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[mgodwan]

@shiv0408 Can you please help review this?

[dblock]

@kkewwei It would be awesome to take this opportunity to add flat_object to https://github.com/opensearch-project/opensearch-api-specification.

[kkewwei]

@kkewwei It would be awesome to take this opportunity to add flat_object to https://github.com/opensearch-project/opensearch-api-specification.

Get it. When it is merged, I will try to implement it.

[github-actions[bot]]

:x: Gradle check result for f4f3a859781bd0f14a3142341f7e97f612279f2d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 4cc0e7d9b53a271300115bf69c9f4a825795e053: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

@sandeshkr419 @shiv0408 @mgodwan @dblock, please have a look when you are free.

The pr will solve three cases, the third one infinite loop with null value is a bit urgent, If I should create new pr to solve it?

[github-actions[bot]]

:x: Gradle check result for d0b5732a43a51feb85e719962de487ab19390e30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for e6be97cd8c4998d6ba950475e6a72bf82545dbcb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for 3d5920465a28aff210f0f9ef8832dec7d77a2485: SUCCESS

[github-actions[bot]]

:x: Gradle check result for 92c8ddd3b1eb170f0e27d1d9c9e39fb19b846a3d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

FAILURE

❌ Gradle check result for 92c8ddd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ReindexBasicTests.testMultipleSources #13913 MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled #15117

[github-actions[bot]]

:x: Gradle check result for 7023bd137e2384d60ec4c0912b37131a0c63d3ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

❌ Gradle check result for 7023bd1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled https://github.com/opensearch-project/OpenSearch/issues/15117

[github-actions[bot]]

:white_check_mark: Gradle check result for 53306f7ff2a367d8beb8e105f114623b04704a40: SUCCESS

[msfroh]

Actually, while I still agree with my prior review comments, they don't affect the usefulness of this fix. I'm going to approve and merge, and I can take care of the cosmetic changes.