OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

add parameters to flat_object type

Open kkewwei opened this issue 1 year ago • 35 comments

Signed-off-by: kkewwei [email protected]

Description

The following open parameters setting are useful, including normalizer, docValues, ignoreAbove, nullValue, similarity, and depthlimit.

normalizer: allow lowercase, uppercase doc_values: allow to set docValues to be false ignore_above: allow to set if the length of a field is go above certain limit then ignore the document. null_value: allow to set nullValue to others similarity: allow to set similarity setting depth_limit: allow to set maximum depth limitation to the JSON document

If there are other useful parameters, you are also welcome to give feedback or continue to add.

Related Issues

Resolves #7137

Check List

  • [x] New functionality includes testing.
    • [x] All tests pass
  • [x] New functionality has been documented.
    • [x] New functionality has javadoc added
  • [x] API changes companion pull request created.
  • [x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • [x] Commits are signed per the DCO using --signoff
  • [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

kkewwei avatar May 28 '24 10:05 kkewwei

:x: Gradle check result for ec4d2566d558ed815a53f2411bc87cbeca4e637d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 28 '24 10:05 github-actions[bot]

:x: Gradle check result for 25c607c10ea50bc117c36fd8e527aa13bab07d84: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 28 '24 10:05 github-actions[bot]

:x: Gradle check result for 819ada8a1f662f012c1a70ddfea10e5318820086: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 28 '24 11:05 github-actions[bot]

:white_check_mark: Gradle check result for 40808f523258dddf72c93f3dc4a741204f24e0c7: SUCCESS

github-actions[bot] avatar May 28 '24 11:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 88.73239% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (034bd2b) to head (f55800b). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java 88.03% 4 Missing and 10 partials :warning:
...rg/opensearch/index/mapper/KeywordFieldMapper.java 84.61% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13853      +/-   ##
============================================
+ Coverage     72.04%   72.07%   +0.03%     
+ Complexity    65093    65058      -35     
============================================
  Files          5314     5314              
  Lines        303541   303616      +75     
  Branches      43921    43934      +13     
============================================
+ Hits         218683   218841     +158     
+ Misses        66946    66820     -126     
- Partials      17912    17955      +43     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 28 '24 11:05 codecov[bot]

:x: Gradle check result for 2607e4bb839ecedc5bf9a7f18121352a2ed0f147: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 28 '24 11:05 github-actions[bot]

:grey_exclamation: Gradle check result for 5bde254a023dba1b6153d9bf72aa6a5e488e3265: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar May 28 '24 11:05 github-actions[bot]

@lukas-vlcek @mingshl please help review.

kkewwei avatar May 28 '24 12:05 kkewwei

:x: Gradle check result for ca4541391f01a89e9c0778be6d6ccaa14bf92c89: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 28 '24 12:05 github-actions[bot]

:x: Gradle check result for a9d7687f59c2edc639f3e39dfbad7573bc85b6a0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 28 '24 13:05 github-actions[bot]

:x: Gradle check result for 639b596c260f2460b31f86dafd1f8b903b5d0ad7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 29 '24 05:05 github-actions[bot]

:x: Gradle check result for 8922f67b4826ba0bcbe5483f7b4ddc314ce42ec4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 29 '24 07:05 github-actions[bot]

:x: Gradle check result for 7fa4722be52f670928ea13c04f6d66b320f9dc65: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 29 '24 08:05 github-actions[bot]

:x: Gradle check result for 120239b7e3d9acd9dbaab5d4dd8b9385a2926732: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 29 '24 11:05 github-actions[bot]

:x: Gradle check result for 0a6e66c17dc0a6d60bf3e14165a35bdf0798ad4a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 29 '24 12:05 github-actions[bot]

:x: Gradle check result for 6a8cf46723404a14d683e3536c44403b097e5ec0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 29 '24 14:05 github-actions[bot]

:x: Gradle check result for 51bbaebd261141391e09f9c0d07530f9e068fcd0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 30 '24 00:05 github-actions[bot]

❌ Gradle check result for 51bbaeb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

S3BlobStoreRepositoryTests.testRequestStats #13887

kkewwei avatar May 30 '24 14:05 kkewwei

@mingshl could you take another look?

kkewwei avatar May 30 '24 14:05 kkewwei

:x: Gradle check result for 99317c4c632ef7588130f11da1d8e8287c70979c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 03 '24 14:06 github-actions[bot]

:x: Gradle check result for ad0962d1a3b6e55d5250cc85986cb48673f87eac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 04 '24 01:06 github-actions[bot]

:x: Gradle check result for 41403f432820a3a0cc6c9288d3743afef7833ff9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 04 '24 05:06 github-actions[bot]

:x: Gradle check result for 93960a78a7e7d2acd5b029b99cb4bf5724a86569: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 04 '24 06:06 github-actions[bot]

@kkewwei Can you rebase this PR and fix the conflicts? Thanks!

andrross avatar Jun 17 '24 15:06 andrross

:x: Gradle check result for 48984b8793fc2a3ff7006c50aa21e825bda8ce7c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 23 '24 06:06 github-actions[bot]

:x: Gradle check result for 0f517b4382d115534bb4b25ab7951dabfd3a473f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 23 '24 08:06 github-actions[bot]

:x: Gradle check result for ceca1864714eadc21cfc17fc6549e1a876e1c9a1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 23 '24 10:06 github-actions[bot]

:x: Gradle check result for 3d8225b9affda8be594709aecea041156b9dce24: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 24 '24 01:06 github-actions[bot]

:grey_exclamation: Gradle check result for 16ef9b989750c536de888fc8e1d2e8ece19ef456: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Jun 24 '24 15:06 github-actions[bot]

:white_check_mark: Gradle check result for ea2bae8937e6561535eff6d69cd25d7131092556: SUCCESS

github-actions[bot] avatar Jun 25 '24 04:06 github-actions[bot]