OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Add TODO for Updating API Spec

Open kkhatua opened this issue 9 months ago • 2 comments

Description

Added a TODO in the checklist for contributors to add API Specs when introducing new user APIs

Related Issues

Resolves #13619

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

kkhatua avatar May 10 '24 05:05 kkhatua

:grey_exclamation: Gradle check result for 873837c60c7b2147b41be0415a59695b2af8b942: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.classMethod
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.classMethod

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar May 10 '24 06:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.48%. Comparing base (b15cb0c) to head (772e339). Report is 274 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13621      +/-   ##
============================================
+ Coverage     71.42%   71.48%   +0.06%     
- Complexity    59978    61027    +1049     
============================================
  Files          4985     5052      +67     
  Lines        282275   287143    +4868     
  Branches      40946    41607     +661     
============================================
+ Hits         201603   205260    +3657     
- Misses        63999    64925     +926     
- Partials      16673    16958     +285     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 06:05 codecov[bot]

:white_check_mark: Gradle check result for ce9471f80b46b1c5a17d943553ffcb1653f3ed8b: SUCCESS

github-actions[bot] avatar May 10 '24 19:05 github-actions[bot]

:grey_exclamation: Gradle check result for 772e3393909ddbcb4dfd8fb8af3a0ed195c41060: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar May 10 '24 19:05 github-actions[bot]

DCO check is failing :(

reta avatar May 10 '24 20:05 reta

I've approved and squashed it with correct sign-off statements

peternied avatar May 10 '24 20:05 peternied

Thanks @reta and @peternied ! I didn't realize that non-code changes to the checklist also required the entire checklist. #ironic 😇

Will take care and follow protocol

kkhatua avatar May 11 '24 01:05 kkhatua