add new role for Offline Nodes

[linuxpi]

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• [ ] New functionality includes testing.
  • [ ] All tests pass
• [ ] New functionality has been documented.
  • [ ] New functionality has javadoc added
• [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• [ ] Commits are signed per the DCO using --signoff
• [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions[bot]]

:white_check_mark: Gradle check result for f8d8f0bdec53bac678381719034f00aed39edf81: SUCCESS

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.47%. Comparing base (b15cb0c) to head (f8d8f0b). Report is 472 commits behind head on main.

Files	Patch %	Lines
.../main/java/org/opensearch/env/NodeEnvironment.java	0.00%	8 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13613      +/-   ##
============================================
+ Coverage     71.42%   71.47%   +0.05%     
- Complexity    59978    61054    +1076     
============================================
  Files          4985     5052      +67     
  Lines        282275   287155    +4880     
  Branches      40946    41608     +662     
============================================
+ Hits         201603   205258    +3655     
- Misses        63999    64946     +947     
- Partials      16673    16951     +278     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dblock]

I am guessing the intent of an offline node is to execute offline tasks. The naming is confusing. A node that's offline is ... offline. I think a better name could be a "worker" or "task" node that is capable of executing tasks, and doesn't serve other purpose than that. The node itself is not offline.

[linuxpi]

I am guessing the intent of an offline node is to execute offline tasks. The naming is confusing. A node that's offline is ... offline. I think a better name could be a "worker" or "task" node that is capable of executing tasks, and doesn't serve other purpose than that. The node itself is not offline.

Thanks for the feedback @dblock . I agree Offline does create some confusion and did spend some time initially to think of a better name but didn't have much luck. But let me give it another shot and come up with a better keyword than "Offline".

If you are interested in getting more context around Offline Nodes, here is a detailed design doc https://github.com/opensearch-project/OpenSearch/issues/13554 and a PR introducing the base library https://github.com/opensearch-project/OpenSearch/pull/13574

[opensearch-trigger-bot[bot]]

This PR is stalled because it has been open for 30 days with no activity.