OpenSearch
OpenSearch copied to clipboard
opensearch-project
Set INDICES_MAX_CLAUSE_COUNT dynamically
Description
Changes the INDICES_MAX_CLAUSE_COUNT_SETTING to be dynamic instead of being static.
This PR is virtually identical to #1527, but there was earlier push back around making this an updateable dynamic setting due to the assumption that users would abuse this setting rather than optimize their underlying query. Lucene has since updated the way the clause counts work and this is now enforced at the indexSearcher level -- https://issues.apache.org/jira/browse/LUCENE-8811.
More info can be found in #12549 around the motivation for this change, but I ended up raising a PR to make a simple dynamic setting.
Related Issues
Resolves #1526 #12549
Check List
- [ ] New functionality includes testing.
- [ ] All tests pass
- [ ] New functionality has been documented.
- [ ] New functionality has javadoc added
- [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
- [ ] Commits are signed per the DCO using --signoff
- [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
- [ ] Public documentation issue/PR created
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.
:x: Gradle check result for dd140e25399970cda85a193230135095191f3f63: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
:x: Gradle check result for 28d5525097634432bf864801947710c4ee92ab68: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 6ccaa23ae69b20f2fb3fff7fec3863c5d012396a: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 4ff1d13d6637f8ef907987834d70eafc94301dcb: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 6321ca826c7aa3e9c72600bcf7153165b4dc2721: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for b11ca0b767cac17dfad4a95113a15ea7cb57bf65: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for a65ceccdf50787e3b44cd1cf558011df7e9d91ae: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for de6d547c3c53bbc553a722e9e4068244694b851e: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 05f8d3029db2e836bb532fd368f8e375d7146446: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 05f8d3029db2e836bb532fd368f8e375d7146446: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 55496a4147198ab87a72c613363a545d4363f5b1: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 15d3f96b3862a08d8bb422b0ac40de2a4dec555c: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 75331e8b52ac820fa2a97f79b00450f1685d4d05: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
❌ Gradle check result for 75331e8: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
https://github.com/opensearch-project/OpenSearch/issues/13600
:x: Gradle check result for a265a2e8502c7f349d380151912a0bfcf79fb04b: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for 7ede1eb36073a4b57666db057ba0f2a1bdb52be5: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.66%. Comparing base (
b15cb0c) to head (e715516). Report is 449 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #13568 +/- ##
============================================
+ Coverage 71.42% 71.66% +0.24%
- Complexity 59978 62032 +2054
============================================
Files 4985 5117 +132
Lines 282275 291713 +9438
Branches 40946 42168 +1222
============================================
+ Hits 201603 209045 +7442
- Misses 63999 65378 +1379
- Partials 16673 17290 +617
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
:x: Gradle check result for e8a8f4d6bab16bddb558bd43eec467e749419941: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for b221209b41064f6aa42ab8f058ac283de01b543f: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:x: Gradle check result for e715516df73ec2d1c61fa08f6ecdddb647fbcdf9: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
Opened https://github.com/opensearch-project/documentation-website/pull/7391/files
:x: Gradle check result for e715516df73ec2d1c61fa08f6ecdddb647fbcdf9: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
❌ Gradle check result for e715516: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
https://github.com/opensearch-project/OpenSearch/issues/14300 https://github.com/opensearch-project/OpenSearch/issues/12651 @msfroh can we merge?