Increase cluster publish timeout in flaky test testStaleClusterManage…

[rahulkarajgikar]

trafficstars

Description

Addresses fix for Flaky Test testStaleClusterManagerNotHijackingMajority which is caused in scenarios of Cluster State not being able to publish within configured timeout of 1s

This change increases the time limit to 2s.

Related Issues

Resolves #1565

Check List

• [x] New functionality includes testing.
  • [x] All tests pass
• [x] New functionality has been documented.
  • [x] New functionality has javadoc added
• [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• [x] Commits are signed per the DCO using --signoff
• [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• [x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions[bot]]

:x: Gradle check result for 0851f2e63d8b12b60e67e781abecc1313c8b1b6c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

@kkmr do examine and comment on flaky tests when you see a gradle build failure when you see it before hitting approve ;)

[dblock]

❌ Gradle check result for 0851f2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupWithDefaultSettings {p0={"search.concurrent_segment_search.enabled":"false"}} org.opensearch.indices.IndicesRequestCacheIT.classMethod

https://github.com/opensearch-project/OpenSearch/issues/12197 https://github.com/opensearch-project/OpenSearch/issues/12308 https://github.com/opensearch-project/OpenSearch/issues/11374

[github-actions[bot]]

:x: Gradle check result for 0851f2e63d8b12b60e67e781abecc1313c8b1b6c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkmr]

@kkmr do examine and comment on flaky tests when you see a gradle build failure when you see it before hitting approve ;)

Will add to my workflow :-)

[github-actions[bot]]

:x: Gradle check result for 0851f2e63d8b12b60e67e781abecc1313c8b1b6c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[rahulkarajgikar]

https://build.ci.opensearch.org/job/gradle-check/38095/

1 failed test causing gradle check to fail:

[org.opensearch.indices.CacheStatsAPIIndicesRequestCacheIT.testNullLevels {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/38095/testReport/junit/org.opensearch.indices/CacheStatsAPIIndicesRequestCacheIT/testNullLevels__p0___opensearch_experimental_feature_pluggable_caching_enabled___true___/)

known flaky test: #13458

[github-actions[bot]]

:x: Gradle check result for 0851f2e63d8b12b60e67e781abecc1313c8b1b6c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

❌ Gradle check result for 0851f2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric

This looks like a new one, @rahulkarajgikar care to take a look, open a new issue if it's unrelated, pls?

[rahulkarajgikar]

looks unrelated since i just increased timeout in test.

Created a new issue for this: #13504

[github-actions[bot]]

:x: Gradle check result for 882eb4f2b9a4b346c8b1e3db197bc1234e636b5e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for c6d19a7c1e8466cc47167beb6d3d367460090a4b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 504d9e6ffe4a889758e0550546afa20e935c8780: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for 0851f2e63d8b12b60e67e781abecc1313c8b1b6c: SUCCESS

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.49%. Comparing base (b15cb0c) to head (0851f2e). Report is 250 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13463      +/-   ##
============================================
+ Coverage     71.42%   71.49%   +0.07%     
- Complexity    59978    60945     +967     
============================================
  Files          4985     5049      +64     
  Lines        282275   286682    +4407     
  Branches      40946    41529     +583     
============================================
+ Hits         201603   204977    +3374     
- Misses        63999    64731     +732     
- Partials      16673    16974     +301     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dblock]

Looks like the backport in https://github.com/opensearch-project/OpenSearch/pull/13513 never happened, @rahulkarajgikar can you please make sure it is backported?