OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

[Remote Routing Table] Initial commit for RemoteRoutingTableService setup

Open himshikha opened this issue 1 year ago • 7 comments

Description

This change is for setting up base service for remote routing table operations.

  • Adds interfaces for remote upload/download operations
  • Adds Cluster settings for enabling Remote routing table feature, disabled by default.
  • Adds FeatureFlag for Remote routing table feature to keep as experimental feature for now.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • [ ] Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

himshikha avatar Apr 19 '24 10:04 himshikha

:x: Gradle check result for 725b2bde2179a717930e7561206beae1fc47e085: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Apr 19 '24 10:04 github-actions[bot]

:x: Gradle check result for d5a17eda019297236129aa698fb3ea5c9e11faff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Apr 19 '24 10:04 github-actions[bot]

@Bukhtawar Added unit tests wherever it made sense. For integration, we want to get the core flow of read-write before merging with cluster state update flow. Getting the interfaces in right now helps with folks able to contribute parallelly.

himshikha avatar Apr 22 '24 11:04 himshikha

:x: Gradle check result for 9176015df2852ef2cb7994f3d931f06c8d7abd14: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Apr 22 '24 11:04 github-actions[bot]

:x: Gradle check result for f29b4a19a3ae82a918fdbffd139f8b196d6c8e85: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 07 '24 08:05 github-actions[bot]

:x: Gradle check result for 7d9badde496038c10955bbffd6f0b010123e6db1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 07 '24 09:05 github-actions[bot]

:x: Gradle check result for ad7ecf5d376254756ca3d7fb61c925dac2f7cd22: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 07 '24 09:05 github-actions[bot]

:x: Gradle check result for 0b70dea140e6564e926396bb75457e1abc07d23a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 14 '24 06:05 github-actions[bot]

:x: Gradle check result for cce1ac875b17a1dd72edcfda4286462cfec18ee8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 15 '24 06:05 github-actions[bot]

:x: Gradle check result for ce04f80ea8b00fc0b552e594a9894be2f16da4de: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

:x: Gradle check result for 2107372af0bf6e56c5a6fcc1f5964ffa2f76512c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

:x: Gradle check result for 6cbbc35de47bb1ae60388adf536464ae50b3a312: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

:x: Gradle check result for 89c33bc27cc2e0911f741dec71ff5374c8b5f063: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 16 '24 11:05 github-actions[bot]

Gradle check failing for flaky tests with existing open bugs.

Test org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode -> #13600

Test org.opensearch.remotestore.CreateRemoteIndexClusterDefaultDocRepIT.testDefaultRemoteStoreNoUserOverrideExceptReplicationTypeSegment -> #11581

Test org.opensearch.remotemigration.RemoteReplicaRecoveryIT.testReplicaRecovery-> #13473

himshikha avatar May 16 '24 11:05 himshikha

:x: Gradle check result for df6410528d220b479e4d21feec46e86c821a2bb4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 24 '24 09:05 github-actions[bot]

:x: Gradle check result for b80c89b26154114820ff661f09ef64a24e1f0d59: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 24 '24 09:05 github-actions[bot]

:x: Gradle check result for 59a0e90f6120619fe160bce9a16a5240525ab84f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 24 '24 09:05 github-actions[bot]

:grey_exclamation: Gradle check result for 51333c9a2e2e466e8eead84d49122f9a16efe9ab: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar May 24 '24 11:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 81.42857% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (b15cb0c) to head (0e5862d). Report is 344 commits behind head on main.

Files Patch % Lines
...ster/routing/remote/RemoteRoutingTableService.java 55.55% 4 Missing and 4 partials :warning:
...nsearch/cluster/metadata/RepositoriesMetadata.java 82.35% 1 Missing and 2 partials :warning:
...rch/node/remotestore/RemoteStoreNodeAttribute.java 77.77% 0 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13304      +/-   ##
============================================
+ Coverage     71.42%   71.59%   +0.17%     
- Complexity    59978    61328    +1350     
============================================
  Files          4985     5066      +81     
  Lines        282275   288261    +5986     
  Branches      40946    41754     +808     
============================================
+ Hits         201603   206383    +4780     
- Misses        63999    64840     +841     
- Partials      16673    17038     +365     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 11:05 codecov[bot]

Gradle check failing with flaky test #12197

himshikha avatar May 27 '24 10:05 himshikha

:x: Gradle check result for 802e04f7b37e11f91c0214869adbb6faf177b0de: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar May 28 '24 18:05 github-actions[bot]

:x: Gradle check result for e486165f703d31de3ba6252e863085859b13eba0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 03 '24 12:06 github-actions[bot]

  1. Add changlog entry
  2. Complete checklist in the pR description
  3. Make sure the build passes

sachinpkale avatar Jun 04 '24 03:06 sachinpkale

:x: Gradle check result for dfc904207e132b725f190c99da8b2db2b503262f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 04 '24 17:06 github-actions[bot]

:x: Gradle check result for 7ad7d05043cb0fce893592d8a5c0a9288b18ab39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Jun 05 '24 07:06 github-actions[bot]

:grey_exclamation: Gradle check result for 0e5862dc27fccd96b826fe5fa6c618311fcd705a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Jun 05 '24 09:06 github-actions[bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13304-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51214092ca532b557b6775ff8620025a51f92fcc
# Push it to GitHub
git push --set-upstream origin backport/backport-13304-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13304-to-2.x.