OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

[Searchable Snapshot] Fix bug of Searchable Snapshot Dependency on repository chunk_size

Open Rishikesh1159 opened this issue 1 year ago • 2 comments

Description

This PR is still in draft version and purpose of this PR is to get some feedback on the approach for resolving the issue. Once approach is finalized I will put this PR out of draft version and refactor with adding some tests. The PR implements logic of fetching blocks from multiple chunks of snapshot file.

Related Issues

Resolves #9676

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • [ ] Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Rishikesh1159 avatar Feb 09 '24 18:02 Rishikesh1159

Compatibility status:

Checks if related components are compatible with change f5ecacb

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git]

github-actions[bot] avatar Feb 09 '24 18:02 github-actions[bot]

:x: Gradle check result for 1b8221360097f3b7d863504bb1853fb02e1abb27: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 09 '24 19:02 github-actions[bot]

:x: Gradle check result for 04de017971af701b178ac88d5d5fad5bce9d2e88: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 19 '24 03:02 github-actions[bot]

:x: Gradle check result for 06918b0c9e5a9d1cb2ce943c6aa946d6b63b6ef8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 19 '24 04:02 github-actions[bot]

:grey_exclamation: Gradle check result for b58f5d2ec592ae6ea84350e572dca3825b3fc7c6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Feb 19 '24 04:02 github-actions[bot]

Codecov Report

Attention: Patch coverage is 97.36842% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.36%. Comparing base (8d84eea) to head (f5ecacb). Report is 1 commits behind head on main.

Files Patch % Lines
...rch/index/store/remote/utils/BlobFetchRequest.java 92.30% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12277   +/-   ##
=========================================
  Coverage     71.35%   71.36%           
+ Complexity    59838    59827   -11     
=========================================
  Files          4972     4972           
  Lines        281783   281797   +14     
  Branches      40910    40913    +3     
=========================================
+ Hits         201075   201097   +22     
+ Misses        64017    63956   -61     
- Partials      16691    16744   +53     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 19 '24 04:02 codecov[bot]

:x: Gradle check result for 06918b0c9e5a9d1cb2ce943c6aa946d6b63b6ef8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 19 '24 19:02 github-actions[bot]

:x: Gradle check result for 06918b0c9e5a9d1cb2ce943c6aa946d6b63b6ef8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 19 '24 22:02 github-actions[bot]

:x: Gradle check result for d3ae7cb8bad19195a68acb9259ec11337cbf0786: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 21 '24 18:02 github-actions[bot]

:x: Gradle check result for 780663992de799ef0ce9308c27f9f4ce4484b1fb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 22 '24 00:02 github-actions[bot]

:x: Gradle check result for 04b75fdbdb9a482b52aa893e298b3d2f8c86a581: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 22 '24 01:02 github-actions[bot]

❌ Gradle check result for 04b75fd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

https://github.com/opensearch-project/OpenSearch/issues/10755

https://github.com/opensearch-project/OpenSearch/issues/12336

Rishikesh1159 avatar Feb 22 '24 15:02 Rishikesh1159

:white_check_mark: Gradle check result for 04b75fdbdb9a482b52aa893e298b3d2f8c86a581: SUCCESS

github-actions[bot] avatar Feb 22 '24 16:02 github-actions[bot]

:x: Gradle check result for 40f47e50f80ff0181c92997beac2a4c9cd273f4f: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 22 '24 21:02 github-actions[bot]

:grey_exclamation: Gradle check result for 40f47e50f80ff0181c92997beac2a4c9cd273f4f: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Feb 22 '24 22:02 github-actions[bot]

:x: Gradle check result for f1a27f8e888889514e1981f82474768c1c345ae4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 26 '24 23:02 github-actions[bot]

:white_check_mark: Gradle check result for f5ecacb14e845462002775a2dfb4ed2ccdbabbdc: SUCCESS

github-actions[bot] avatar Feb 27 '24 00:02 github-actions[bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12277-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3125b948029609f354d3153f8ca6391638daefc7
# Push it to GitHub
git push --set-upstream origin backport/backport-12277-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12277-to-2.x.

@Rishikesh1159 Looks like a backport was missed, causing the conflict on this PR's backport. Can you create the manual backport after #12485 is merged?

andrross avatar Feb 27 '24 22:02 andrross

@Rishikesh1159 Looks like a backport was missed, causing the conflict on this PR's backport. Can you create the manual backport after #12485 is merged?

@Rishikesh1159 / @andrross opensearch-bot took care of it :)

kotwanikunal avatar Feb 27 '24 23:02 kotwanikunal