OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Bug/12065 refac glob matching

Open robinf95 opened this issue 1 year ago • 7 comments

Description

Refactored Glob.globMatch by using iterative approach

Related Issues

Resolves #12065

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • [ ] Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

robinf95 avatar Feb 07 '24 08:02 robinf95

:x: Gradle check result for fa59c6c607707f1c9bf2bbd8a40c22f5cf5bf4fa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 07 '24 08:02 github-actions[bot]

Compatibility status:

Checks if related components are compatible with change 5b6ee3f

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions[bot] avatar Feb 07 '24 08:02 github-actions[bot]

Build still failing please check and resubmit.

deshsidd avatar Feb 07 '24 23:02 deshsidd

:x: Gradle check result for 79117b61590a2c37f968a54c468877a7f3d2f544: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 09 '24 07:02 github-actions[bot]

:x: Gradle check result for 5b6ee3f2960c702430e81f13ba0d757032caa1f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Feb 09 '24 09:02 github-actions[bot]

This PR is stalled because it has been open for 30 days with no activity.

This PR is stalled because it has been open for 30 days with no activity.

@cwperks The original issue https://github.com/opensearch-project/OpenSearch/issues/12065 seems to be resolved by https://github.com/opensearch-project/OpenSearch/pull/13104 . Can we close this PR as it is not needed?

kkhatua avatar Jul 30 '24 18:07 kkhatua

@kkhatua Yes, this can be closed.

cwperks avatar Jul 30 '24 18:07 cwperks