OpenSearch
OpenSearch copied to clipboard

Published 20 hours ago •

opensearch-project

Reame
Issues

Shard id awareness of SearchLookup

Open anti-social opened this issue 4 years ago • 49 comments

Signed-off-by: Oleksandr Koval [email protected]

Description

Add shardId field for SearchLookup.

Issues Resolved

#1062

Check List

[ ] New functionality includes testing.
- [ ] All tests pass
[ ] New functionality has been documented.
- [ ] New functionality has javadoc added
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Aug 09 '21 09:08 anti-social

:white_check_mark: DCO Check Passed a2be8c04219d7b6aaa8ee0a4107bfee73d1b00a4

Aug 09 '21 09:08 opensearch-ci-bot

:white_check_mark: Gradle Wrapper Validation success a2be8c04219d7b6aaa8ee0a4107bfee73d1b00a4

Aug 09 '21 09:08 opensearch-ci-bot

:white_check_mark: DCO Check Passed 3314a8069f91480db129fac4e0f92507ca42a768

Aug 09 '21 09:08 opensearch-ci-bot

:x: Gradle Precommit failure a2be8c04219d7b6aaa8ee0a4107bfee73d1b00a4 Log 902

Aug 09 '21 09:08 opensearch-ci-bot

:white_check_mark: Gradle Wrapper Validation success 3314a8069f91480db129fac4e0f92507ca42a768

Aug 09 '21 09:08 opensearch-ci-bot

:white_check_mark: Gradle Precommit success 3314a8069f91480db129fac4e0f92507ca42a768

Aug 09 '21 09:08 opensearch-ci-bot

Can one of the admins verify this patch?

Sep 29 '21 21:09 opensearch-ci-bot

start gradle check

Oct 12 '21 23:10 adnapibar

:x: Gradle Check failure 3314a8069f91480db129fac4e0f92507ca42a768 Log 671

Oct 12 '21 23:10 opensearch-ci-bot

:white_check_mark: Gradle Wrapper Validation success 3314a8069f91480db129fac4e0f92507ca42a768

Oct 26 '21 15:10 opensearch-ci-bot

:white_check_mark: DCO Check Passed 3314a8069f91480db129fac4e0f92507ca42a768

Oct 26 '21 15:10 opensearch-ci-bot

:white_check_mark: Gradle Precommit success 3314a8069f91480db129fac4e0f92507ca42a768

Oct 26 '21 15:10 opensearch-ci-bot

@anti-social , can you look into the failure and resolve the conflict.

Oct 28 '21 16:10 anasalkouz

:white_check_mark: Gradle Wrapper Validation success 5c971a9754d3cf3dbe4f9beecd66e7c8acf076fd

Nov 02 '21 09:11 opensearch-ci-bot

:white_check_mark: Gradle Precommit success 5c971a9754d3cf3dbe4f9beecd66e7c8acf076fd

Nov 02 '21 10:11 opensearch-ci-bot

:x: Gradle Check failure 5c971a9754d3cf3dbe4f9beecd66e7c8acf076fd Log 950

Nov 02 '21 10:11 opensearch-ci-bot

Think this test are not related to the changes:

org.opensearch.cluster.ClusterHealthIT > testHealthOnMasterFailover FAILED

./gradlew :server:internalClusterTest --tests "org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover" passed on my machine.

Possibly checks should be retried.

Nov 03 '21 18:11 anti-social

start gradle check

Nov 05 '21 01:11 tlfeng

:white_check_mark: Gradle Check success 5c971a9754d3cf3dbe4f9beecd66e7c8acf076fd Log 991

Nov 05 '21 01:11 opensearch-ci-bot

:white_check_mark: Gradle Wrapper Validation success 4254bab0ddedb8716ef5d9f7247956d68c3b89b6

Nov 08 '21 11:11 opensearch-ci-bot

:white_check_mark: Gradle Precommit success 4254bab0ddedb8716ef5d9f7247956d68c3b89b6

Nov 08 '21 11:11 opensearch-ci-bot

:white_check_mark: Gradle Check success 4254bab0ddedb8716ef5d9f7247956d68c3b89b6 Log 1006

Nov 08 '21 12:11 opensearch-ci-bot

:x: Gradle Check failure 4254bab0ddedb8716ef5d9f7247956d68c3b89b6 Log 1425

Dec 10 '21 17:12 opensearch-ci-bot

:white_check_mark: Gradle Check success 4254bab0ddedb8716ef5d9f7247956d68c3b89b6 Log 1473

Dec 14 '21 00:12 opensearch-ci-bot

@anti-social : Can you please explain the use case here ?

Jun 01 '22 21:06 dreamer-89

We have an index with quite huge documents and something like a bid platform. So we want to quickly update only a single document field without reindexing full document. We implemented a plugin that works similar to Solr ExternalFileField but in a slightly more optimized way. There is a service that fetches data from Kafka and puts updates into special hashmap-like files. Data in these files are partitioned in exactly the same way as documents in shards (data in a file corresponds to a shard). Then when a search request is executed we should to know a shard id to be able to choose right file with bids.

Jun 09 '22 15:06 anti-social

@anti-social are you still working on this change?

Aug 03 '22 22:08 kartg

@anti-social Hey, do you want to move ahead and work on the tests to close out this issue?

Mar 13 '23 19:03 Poojita-Raj

I'll try to do finish it soon

On Mon, Mar 13, 2023, 21:16 Poojita Raj @.***> wrote:

@anti-social https://github.com/anti-social Hey, do you want to move ahead and work on the tests to close out this issue?

— Reply to this email directly, view it on GitHub https://github.com/opensearch-project/OpenSearch/pull/1063#issuecomment-1466806828, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKV2Y5XHYOVR47HUMWH5LW35XANANCNFSM5BZTMGIQ . You are receiving this because you were mentioned.Message ID: @.***>

Mar 14 '23 20:03 anti-social

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE :x:
URL: https://build.ci.opensearch.org/job/gradle-check/12946/
CommitID: d2b3473b0c438d4b9e89851bdceaf458db514e14 Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Mar 27 '23 12:03 github-actions[bot]