OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Fixed Allocation Explain API in batch mode

Open shiv0408 opened this issue 2 years ago • 7 comments

Description

This Pull request fixes the explainUnassignedShardAllocation method to use the correct batch allocator to find unassigned explain reason in case the batch mode is enabled.

Related Issues

This is part of improvement for #5098 Related to #8098

Dependency

This change is dependent on #8865, which needs to be merged before merging this PR

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [ ] Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] GitHub issue/PR created in OpenSearch documentation repo for the required public documentation changes (#[Issue/PR number])

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

shiv0408 avatar Oct 04 '23 00:10 shiv0408

Compatibility status:

Checks if related components are compatible with change a730ff5

Incompatible components

Skipped components

Compatible components

github-actions[bot] avatar Oct 04 '23 00:10 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/26810/
  • CommitID: e35add0e10a70d050453e3832796c3a5f3765212 Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Oct 04 '23 00:10 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE :x:
  • URL: https://build.ci.opensearch.org/job/gradle-check/28109/
  • CommitID: 354a9455dbbee5819ba01c69a20f4e0ce8a6d481 Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Oct 17 '23 08:10 github-actions[bot]

:x: Gradle check result for a730ff5a460480772a0cd0afc00d82064fa22cdf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Nov 30 '23 12:11 github-actions[bot]

This PR is stalled because it has been open for 30 days with no activity.

Hi @shiv0408, Is this being worked upon? Feel free to reach out to maintainers for further reviews.

ticheng-aws avatar Jan 08 '24 23:01 ticheng-aws

This PR is stalled because it has been open for 30 days with no activity.

Discarding this PR as the core logic of explainUnassignedShardAllocation written in this PR is already added in #8746. Will add the test added in this PR to the above mentioned PR only.

shiv0408 avatar Mar 13 '24 11:03 shiv0408