OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Added an optional DEVELOPER_GUIDE tool

Open dtaivpp opened this issue 2 years ago • 11 comments

Description

Added optional tool SDKMan in DEVELOPER_GUIDE to simplify JDK environment installation and sourcing.

Related Issues

Resolves #[Issue number to be closed when this PR is merged] N/A

Check List

  • [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dtaivpp avatar Sep 20 '23 00:09 dtaivpp

Compatibility status:

Checks if related components are compatible with change 89a9011

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

github-actions[bot] avatar Sep 20 '23 01:09 github-actions[bot]

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE :grey_exclamation:
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDeleteOperations
  • URL: https://build.ci.opensearch.org/job/gradle-check/25886/
  • CommitID: 89a90117059d070d50c4a19eed14c744064eea7d Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] avatar Sep 20 '23 01:09 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.10%. Comparing base (d7aa6dd) to head (89a9011). Report is 813 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10132      +/-   ##
============================================
+ Coverage     71.02%   71.10%   +0.08%     
- Complexity    58078    58088      +10     
============================================
  Files          4825     4825              
  Lines        274032   274101      +69     
  Branches      39930    39946      +16     
============================================
+ Hits         194628   194906     +278     
+ Misses        63067    62802     -265     
- Partials      16337    16393      +56     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 20 '23 01:09 codecov[bot]

We should also change the PR title to be imperative style (i.e. Add an optional DEVELOPER_GUIDE tool instead of Added ...) because the title will be used as the commit message on merge

BhumikaSaini-Amazon avatar Oct 13 '23 17:10 BhumikaSaini-Amazon

This PR is stalled because it has been open for 30 days with no activity.

Hi @dtaivpp, Is this being worked upon? Feel free to reach out to maintainers for further reviews.

ticheng-aws avatar Jan 06 '24 00:01 ticheng-aws

@ticheng-aws sorry for the delay I’ll get these changes in.

dtaivpp avatar Jan 06 '24 03:01 dtaivpp

This PR is stalled because it has been open for 30 days with no activity.

@dtaivpp Checking again if you plan to clean this up ?

sohami avatar Feb 14 '24 01:02 sohami

This PR is stalled because it has been open for 30 days with no activity.

This PR is stalled because it has been open for 30 days with no activity.