OpenSearch-Dashboards
OpenSearch-Dashboards copied to clipboard
[discover] memoization plus not setting the user query language
Description
Optimize the language selector preventing too many renders and potentially setting of the language triggering an update.
Issues Resolved
n/a
Screenshot
Testing the changes
Changelog
Check List
- [ ] All tests pass
- [ ]
yarn test:jest - [ ]
yarn test:jest_integration
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update CHANGELOG.md
- [ ] Commits are signed per the DCO using --signoff
β Empty Changelog Section
The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.
Codecov Report
Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.
Project coverage is 60.86%. Comparing base (
79fed30) to head (42c611b). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| .../data/public/ui/query_editor/language_selector.tsx | 55.55% | 7 Missing and 5 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #8685 +/- ##
==========================================
- Coverage 60.86% 60.86% -0.01%
==========================================
Files 3793 3793
Lines 90447 90456 +9
Branches 14203 14204 +1
==========================================
+ Hits 55053 55057 +4
- Misses 31906 31910 +4
- Partials 3488 3489 +1
| Flag | Coverage Ξ | |
|---|---|---|
| Linux_1 | 29.08% <ΓΈ> (ΓΈ) |
|
| Linux_2 | 56.40% <ΓΈ> (ΓΈ) |
|
| Linux_3 | 37.69% <55.55%> (+<0.01%) |
:arrow_up: |
| Linux_4 | 29.85% <ΓΈ> (ΓΈ) |
|
| Windows_1 | 29.10% <ΓΈ> (ΓΈ) |
|
| Windows_2 | 56.35% <ΓΈ> (ΓΈ) |
|
| Windows_3 | 37.69% <55.55%> (+<0.01%) |
:arrow_up: |
| Windows_4 | 29.85% <ΓΈ> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
β Create Or Update Content
Something went wrong. Error creating or updating content in repository. Please try again.