OpenSearch-Dashboards
OpenSearch-Dashboards copied to clipboard
bump `url` to 0.11.4
Description
See https://github.com/opensearch-project/OpenSearch-Dashboards/issues/8379 for the problem.
In http, url.format() is used to format query object into URL
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/64ed61bd9709b62d4fbc3de98656570e7e6bc782/src/core/public/http/fetch.ts#L151-L154
This method does not work correctly on browser side, that if query is
{ "a": "a", "b": [], "c": "c" }
instead of ?a=a&c=c, it returns ?a=a&&c=c. The root cause is somewhere inside querystring.stringify in the url module, and updating url to latest 0.11.4 fixes this behavior (possibly because url changed to qs instead of querystring).
url npm module is introduced by aws-sdk, and in latest v2.1691.0 it still uses [email protected], so we cannot bump aws-sdk to upgrade url. yarn.lock changes are from transitive dependency changes in url upgrade.
Issues Resolved
closes #8379
Screenshot
Testing the changes
Changelog
- fix: bump url to 0.11.4
Check List
- [ ] All tests pass
- [ ]
yarn test:jest - [ ]
yarn test:jest_integration
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update CHANGELOG.md
- [ ] Commits are signed per the DCO using --signoff