OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[MDS][Enhancement] Deprecate the non-MDS data connection endpoint for direct query data source

Open RyanL1997 opened this issue 4 months ago • 0 comments

Description

In version 2.16, the migration of direct query data source was done in data source management plugin. For supporting MDS, it originally has 2 versions of same endpoints, such as,

  • /api/directquery/dataconnections and
  • /api/directquery/dataconnections/dataSourceMDSId={dataSourceMDSId?}, for with and without MDS support.

The 2 versions of endpoints are served the same purpose. The non-mds endpoints is only being used when MDS feature flag is disabled- for local cluster only environment. so that the best practice is to unified the usage and deprecate the non-mds version, since the mds endpoints are also supporting local cluster calls by passing in the '' as cluster ID.

OpenSearch Version

2.16 +

Dashboards Version**

2.16 +

Plugins

OSD core - data source management

Reference

  • Migration PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7143
  • data_connections_router class: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/9eae14851672fad87d077856c2af47a8e181b671/src/plugins/data_source_management/server/routes/data_connections_router.ts
  • sample usage of non-mds data connection endpoint: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/9eae14851672fad87d077856c2af47a8e181b671/src/plugins/data_source_management/public/components/utils.ts#L65

RyanL1997 avatar Oct 09 '24 23:10 RyanL1997