OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[Workspace]Refactor workspace form UI

Open wanglam opened this issue 1 year ago β€’ 2 comments

Description

  1. Use full width for workspace form in workspace create and update page
  2. Add form error callout
  3. Remove color picker
  4. Add %current_user% to permission settings
  5. Validate owner is required in permissions settings

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: [Workspace] Refactor workspace form UI

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [ ] Commits are signed per the DCO using --signoff

wanglam avatar Jul 01 '24 09:07 wanglam

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions[bot] avatar Jul 01 '24 09:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 98.05195% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.61%. Comparing base (b422791) to head (a7b3d1d). Report is 336 commits behind head on main.

Files with missing lines Patch % Lines
...orkspace/public/components/workspace_form/utils.ts 97.72% 0 Missing and 2 partials :warning:
src/plugins/workspace/server/routes/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7133      +/-   ##
==========================================
+ Coverage   67.56%   67.61%   +0.05%     
==========================================
  Files        3469     3471       +2     
  Lines       68479    68576      +97     
  Branches    11130    11155      +25     
==========================================
+ Hits        46266    46368     +102     
+ Misses      19511    19507       -4     
+ Partials     2702     2701       -1     
Flag Coverage Ξ”
Linux_1 33.28% <98.05%> (+0.15%) :arrow_up:
Linux_2 55.26% <ΓΈ> (ΓΈ)
Linux_3 45.30% <ΓΈ> (-0.01%) :arrow_down:
Linux_4 34.71% <ΓΈ> (ΓΈ)
Windows_1 33.31% <98.05%> (+0.15%) :arrow_up:
Windows_2 55.21% <ΓΈ> (ΓΈ)
Windows_3 45.32% <ΓΈ> (ΓΈ)
Windows_4 34.71% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 01 '24 09:07 codecov[bot]