OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[Discover-Next] Async Query Support

Open sejli opened this issue 1 year ago • 4 comments

Description

  • Adds async query support
  • Currently using regex to identify datasource, will switch to using datasource selector once that implementation is in

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

sejli avatar Jun 25 '24 17:06 sejli

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7104.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

github-actions[bot] avatar Jun 25 '24 17:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.56%. Comparing base (20cefab) to head (33d2db7). Report is 1 commits behind head on main.

Files Patch % Lines
.../data/common/search/search_source/search_source.ts 0.00% 6 Missing and 1 partial :warning:
...h_query/opensearch_query/build_opensearch_query.ts 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7104   +/-   ##
=======================================
  Coverage   67.56%   67.56%           
=======================================
  Files        3469     3469           
  Lines       68478    68486    +8     
  Branches    11130    11133    +3     
=======================================
+ Hits        46265    46275   +10     
+ Misses      19511    19508    -3     
- Partials     2702     2703    +1     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.24% <0.00%> (-0.02%) :arrow_down:
Linux_3 45.30% <0.00%> (-0.01%) :arrow_down:
Linux_4 34.71% <0.00%> (-0.01%) :arrow_down:
Windows_1 33.17% <0.00%> (+0.01%) :arrow_up:
Windows_2 55.19% <0.00%> (-0.02%) :arrow_down:
Windows_3 45.30% <0.00%> (-0.02%) :arrow_down:
Windows_4 34.71% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 25 '24 17:06 codecov[bot]

https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7104#issuecomment-2189543868 i wouldn't do a manual changelog i would install the bot

kavilla avatar Jun 25 '24 18:06 kavilla

i like it just some comments about the class

kavilla avatar Jun 25 '24 18:06 kavilla

@sejli Whats left here?

ashwin-pc avatar Jul 06 '24 11:07 ashwin-pc