OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

Condence context menus

Open AMoo-Miki opened this issue 1 year ago • 5 comments

Hold for @kgcreative and Viraj's signoff.

condenced

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [ ] Commits are signed per the DCO using --signoff

AMoo-Miki avatar Jun 19 '24 00:06 AMoo-Miki

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

github-actions[bot] avatar Jun 19 '24 00:06 github-actions[bot]

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

github-actions[bot] avatar Jun 19 '24 00:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.44%. Comparing base (a4aa682) to head (3525031). Report is 376 commits behind head on main.

Files with missing lines Patch % Lines
...gins/share/public/components/url_panel_content.tsx 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7057      +/-   ##
==========================================
- Coverage   67.44%   67.44%   -0.01%     
==========================================
  Files        3444     3445       +1     
  Lines       67865    67886      +21     
  Branches    11027    11037      +10     
==========================================
+ Hits        45772    45783      +11     
- Misses      19429    19434       +5     
- Partials     2664     2669       +5     
Flag Coverage Δ
Linux_1 33.07% <0.00%> (ø)
Linux_2 55.11% <ø> (ø)
Linux_3 45.25% <ø> (+0.01%) :arrow_up:
Linux_4 ?
Windows_1 33.10% <0.00%> (ø)
Windows_2 55.06% <ø> (ø)
Windows_3 45.25% <ø> (+0.01%) :arrow_up:
Windows_4 34.86% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 19 '24 00:06 codecov[bot]

is the proposal within OSD or are these examples for potentially having the default values in OUI be smaller? so it hits the entire app?

kavilla avatar Jun 20 '24 00:06 kavilla

is the proposal within OSD or are these examples for potentially having the default values in OUI be smaller? so it hits the entire app?

There is a big collection of changes. Some are done globally within OUI (via a new theme) and some are done surgically. There will most likely be some that will go behind a config flag too.

AMoo-Miki avatar Jun 28 '24 20:06 AMoo-Miki

@AMoo-Miki seem test snapshot update was missed, that cause CI to fail https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/9966986613/job/27539949592?pr=7254

Hailong-am avatar Jul 17 '24 03:07 Hailong-am