OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

refactor: deprecate resize-observer-polyfill for native ResizeObserver

Open virajsanghvi opened this issue 1 year ago • 3 comments

Description

Removes resize-observer-polyfill in favor of native implementation

Issues Resolved

Closes https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3824

Screenshot

Testing the changes

Updated existing unit tests and manually validated changes.

One case doesn't have existing unit tests and not super trivial to add, but can add if necessary.

Changelog

  • refactor: deprecate resize-observer-polyfill for native ResizeObserver [3824]

Check List

  • [ ] All tests pass
    • [x] yarn test:jest
    • [ ] yarn test:jest_integration
  • [x] New functionality includes testing.
  • [x] New functionality has been documented.
  • [x] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

virajsanghvi avatar Jun 11 '24 23:06 virajsanghvi

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "refactor". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions[bot] avatar Jun 12 '24 00:06 github-actions[bot]

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "refactor". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions[bot] avatar Jun 12 '24 00:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.63%. Comparing base (5ee6f58) to head (a1c7712). Report is 527 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7007      +/-   ##
==========================================
+ Coverage   67.45%   67.63%   +0.18%     
==========================================
  Files        3448     3443       -5     
  Lines       67964    67708     -256     
  Branches    11057    10977      -80     
==========================================
- Hits        45843    45797      -46     
+ Misses      19447    19251     -196     
+ Partials     2674     2660      -14     
Flag Coverage Δ
Linux_1 33.10% <100.00%> (+<0.01%) :arrow_up:
Linux_2 55.06% <100.00%> (+<0.01%) :arrow_up:
Linux_3 ?
Linux_4 34.83% <100.00%> (+<0.01%) :arrow_up:
Windows_1 33.12% <100.00%> (+<0.01%) :arrow_up:
Windows_2 55.01% <100.00%> (+<0.01%) :arrow_up:
Windows_3 45.46% <100.00%> (+0.20%) :arrow_up:
Windows_4 34.83% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 12 '24 00:06 codecov[bot]