OpenSearch-Dashboards
OpenSearch-Dashboards copied to clipboard
[WIP] experimental placeholder
Signed-off-by: Ryan Liang [email protected]
Description
Create a centralized datasource panel for consuming both Zero-ETL datasources and OpenSearch datasources
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
- [ ] All tests pass
- [ ]
yarn test:jest - [ ]
yarn test:jest_integration
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update CHANGELOG.md
- [ ] Commits are signed per the DCO using --signoff Signed-off-by: Ryan Liang [email protected]
ℹ️ Manual Changeset Creation Reminder
Please ensure manual commit for changeset file 6852.yml under folder changelogs/fragments to complete this PR.
If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.
For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.
❌ Changeset File Not Added Yet
Please ensure manual commit for changeset file 6852.yml under folder changelogs/fragments to complete this PR. File still missing.
Codecov Report
Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.
Project coverage is 59.17%. Comparing base (
b85e177) to head (324f0f1).
| Files | Patch % | Lines |
|---|---|---|
| ...rc/plugins/data_source_management/public/plugin.ts | 0.00% | 13 Missing :warning: |
| .../data_source_management/public/components/utils.ts | 50.00% | 1 Missing :warning: |
:exclamation: There is a different number of reports uploaded between BASE (b85e177) and HEAD (324f0f1). Click for more details.
HEAD has 2 uploads less than BASE
Flag BASE (b85e177) HEAD (324f0f1) Linux_3 1 0 Windows_3 1 0
Additional details and impacted files
@@ Coverage Diff @@
## main #6852 +/- ##
==========================================
- Coverage 67.45% 59.17% -8.28%
==========================================
Files 3448 3107 -341
Lines 67964 60383 -7581
Branches 11057 9554 -1503
==========================================
- Hits 45845 35733 -10112
- Misses 19446 22731 +3285
+ Partials 2673 1919 -754
| Flag | Coverage Δ | |
|---|---|---|
| Linux_1 | 33.10% <ø> (ø) |
|
| Linux_2 | 55.06% <ø> (ø) |
|
| Linux_3 | ? |
|
| Linux_4 | 34.84% <41.66%> (+0.01%) |
:arrow_up: |
| Windows_1 | 33.12% <ø> (ø) |
|
| Windows_2 | 55.01% <ø> (ø) |
|
| Windows_3 | ? |
|
| Windows_4 | 34.84% <41.66%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Do we have a design for this? Im concerned that we are hardcoding datasources logic here. Ideally the code in OSD should be limited to features that are natively available in OS core and all additional functionality should be moved to a plugin and brought in using core OSD apis. See how the Multi Query language feature brings in additional query language support using such API's
+1.
Will look at this PR tmrw. One general feedback would be it seems like very specific components that can be genericized and registered to
❌ Changeset File Not Added Yet
Please ensure manual commit for changeset file 6852.yml under folder changelogs/fragments to complete this PR. File still missing.
Hi @RyanL1997 , is this PR targeting 2.15 or 2.16?
Hi @RyanL1997 , is this PR targeting 2.15 or 2.16?
Hi @BionIT, this is PR will not go into 2.15 release branch.
❌ Changeset File Not Added Yet
Please ensure manual commit for changeset file 6852.yml under folder changelogs/fragments to complete this PR. File still missing.
❌ Changeset File Not Added Yet
Please ensure manual commit for changeset file 6852.yml under folder changelogs/fragments to complete this PR. File still missing.
❌ Changeset File Not Added Yet
Please ensure manual commit for changeset file 6852.yml under folder changelogs/fragments to complete this PR. File still missing.