OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

Add .lycheeignore and changelogs/fragments to workflow ignore

Open sejli opened this issue 1 year ago β€’ 2 comments

Description

Adds .lycheeignore and changelogs/fragments/** to skip build_and_test and cypress workflows.

Issues Resolved

#6772

Screenshot

N/A

Testing the changes

N/A

Changelog

  • chore: Add .lycheeignore and changelogs/fragments to workflow ignore

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

sejli avatar May 15 '24 15:05 sejli

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions[bot] avatar May 15 '24 15:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.42%. Comparing base (6a20742) to head (738f577).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6795   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files        3444     3444           
  Lines       67781    67781           
  Branches    11023    11023           
=======================================
+ Hits        45702    45704    +2     
+ Misses      19413    19412    -1     
+ Partials     2666     2665    -1     
Flag Coverage Ξ”
Linux_1 33.11% <ΓΈ> (ΓΈ)
Linux_2 55.04% <ΓΈ> (ΓΈ)
Linux_3 45.25% <ΓΈ> (-0.01%) :arrow_down:
Linux_4 34.85% <ΓΈ> (ΓΈ)
Windows_1 33.13% <ΓΈ> (ΓΈ)
Windows_2 55.00% <ΓΈ> (ΓΈ)
Windows_3 45.26% <ΓΈ> (ΓΈ)
Windows_4 34.85% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 15:05 codecov[bot]

Hi @sejli , are we targeting to get this PR into 2.15?

BionIT avatar Jun 05 '24 03:06 BionIT

Hi @BionIT, this PR should be targeting 2.15.

sejli avatar Jun 05 '24 16:06 sejli

Hi @BionIT, this PR should be targeting 2.15.

Could you address the comments from @manasvinibs ?

BionIT avatar Jun 05 '24 19:06 BionIT