OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[Multiple datasource] Adjust the padding size for aggregated view

Open yujin-emma opened this issue 9 months ago • 4 comments

Description

Adjust the padding size for aggregated view

Issues Resolved

Screenshot

Screenshot 2024-05-08 at 13 38 37 Screenshot 2024-05-08 at 13 38 21

Testing the changes

Changelog

  • fix: Adjust the padding size for aggregated view

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [ ] Commits are signed per the DCO using --signoff

yujin-emma avatar May 03 '24 21:05 yujin-emma

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions[bot] avatar May 03 '24 21:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.52%. Comparing base (f728b5a) to head (0891292).

Files Patch % Lines
...ce_aggregated_view/data_source_aggregated_view.tsx 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6715      +/-   ##
==========================================
- Coverage   67.55%   67.52%   -0.04%     
==========================================
  Files        3428     3428              
  Lines       67340    67341       +1     
  Branches    10994    10995       +1     
==========================================
- Hits        45494    45472      -22     
- Misses      19176    19245      +69     
+ Partials     2670     2624      -46     
Flag Coverage Δ
Linux_1 33.04% <ø> (ø)
Linux_2 ?
Linux_3 45.16% <0.00%> (+<0.01%) :arrow_up:
Linux_4 34.73% <0.00%> (-0.01%) :arrow_down:
Windows_1 33.06% <ø> (ø)
Windows_2 55.10% <ø> (ø)
Windows_3 45.17% <0.00%> (-0.01%) :arrow_down:
Windows_4 34.73% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '24 21:05 codecov[bot]

@yujin-emma can you please utilize the Changelog section. And remove the manual update to the changelog.md.

By utilizing that and installing the really awesome changelog by @BigSamu bot I am able to automatically generate the release notes instead of manually creating them.

kavilla avatar May 04 '24 10:05 kavilla

@yujin-emma you could config this https://github.com/apps/opensearch-changeset-bot then update Description in the PR. This will help to add the changeset file for you automatically. We will block any PRs that manually update changelog after 4/17. Thx.

ananzh avatar May 05 '24 04:05 ananzh