OpenSearch-Dashboards
OpenSearch-Dashboards copied to clipboard
[MDS] Modify toast + popover warning to include incompatible datasources
Description
This PR modifies the toast + popover message to cover the edge case that datasources exist but all datasources are filtered out by the dataSourceFilter for the multi-select, selectable, and aggregated view (both read-all and read-select) components
Issues Resolved
N/A
Screenshot
Toast message + popover should be shown below.
Testing the changes
Note
All testing was done when data_sources.enabled: true and data_source.hideLocalCluster: true (these are the only two configurations that can show the NoDataSources component + toast.
Both cases should show the Manage data sources button.
When datasources are added, but the dataSourceFilter = (_) => false
- This should show the message
No data sources connected yet. Connect your data sources to get started.
When there are no datasources added
- This should show the message
No compatible data sources are available. Add a compatible data source.
Changelog
- fix: [MDS] Add a new message to data source components when there are no compatible datasources
Check List
- [ ] All tests pass
- [ ]
yarn test:jest - [ ]
yarn test:jest_integration
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update CHANGELOG.md
- [ ] Commits are signed per the DCO using --signoff
Codecov Report
Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 67.75%. Comparing base (
45c7c15) to head (d8678b5).
| Files | Patch % | Lines |
|---|---|---|
| ..._multi_selectable/data_source_multi_selectable.tsx | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #6678 +/- ##
==========================================
+ Coverage 67.73% 67.75% +0.02%
==========================================
Files 3417 3417
Lines 66948 66956 +8
Branches 10892 10895 +3
==========================================
+ Hits 45344 45366 +22
+ Misses 18958 18945 -13
+ Partials 2646 2645 -1
| Flag | Coverage Δ | |
|---|---|---|
| Linux_1 | 33.16% <ø> (ø) |
|
| Linux_2 | 55.57% <ø> (ø) |
|
| Linux_3 | 45.26% <88.23%> (+<0.01%) |
:arrow_up: |
| Linux_4 | 34.88% <29.41%> (+<0.01%) |
:arrow_up: |
| Windows_1 | 33.20% <ø> (+0.02%) |
:arrow_up: |
| Windows_2 | 55.54% <ø> (ø) |
|
| Windows_3 | 45.27% <88.23%> (+0.01%) |
:arrow_up: |
| Windows_4 | 34.88% <29.41%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@huyaboo do you have the changelog bot installed? it might be the reason why the file isn't generated
@huyaboo do you have the changelog bot installed? it might be the reason why the file isn't generated
I did install it. It could be that i force pushed changes to this branch