OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[Workspace] Support feature quantities in workspace list page

Open raintygao opened this issue 10 months ago • 6 comments

Description

Support feature selection quantities in workspace list page

Screenshot

image

Changelog

  • feat: [Workspace] Support feature quantities in workspace list page

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [ ] Commits are signed per the DCO using --signoff

raintygao avatar Apr 24 '24 03:04 raintygao

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.49%. Comparing base (460428c) to head (a89f35c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6627      +/-   ##
==========================================
- Coverage   67.79%   67.49%   -0.30%     
==========================================
  Files        3413     2655     -758     
  Lines       66755    50623   -16132     
  Branches    10861     9170    -1691     
==========================================
- Hits        45254    34170   -11084     
+ Misses      18857    14206    -4651     
+ Partials     2644     2247     -397     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.63% <ø> (ø)
Linux_3 45.26% <ø> (+0.01%) :arrow_up:
Linux_4 34.91% <ø> (ø)
Windows_1 ?
Windows_2 55.59% <ø> (ø)
Windows_3 ?
Windows_4 34.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 24 '24 03:04 codecov[bot]

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions[bot] avatar Apr 24 '24 05:04 github-actions[bot]

@raintygao https://github.com/apps/opensearch-changeset-bot could you please install the app into your forked repo? I think this PR deserves a changelog.

SuZhou-Joe avatar Apr 24 '24 05:04 SuZhou-Joe

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions[bot] avatar Apr 24 '24 05:04 github-actions[bot]

i think it would be cool to make the #/# a tool tip, and it displays the names of the selected apps

Thanks for your suggestion. That's cool. I will discuss this with designer.

raintygao avatar Apr 28 '24 08:04 raintygao

Hi @kavilla , could you help approve again? Seems your approval was dismissed because of my commit to update description.

raintygao avatar Apr 29 '24 02:04 raintygao

Hi @raintygao, is this PR targeting 2.15 or 2.16?

BionIT avatar Jun 05 '24 03:06 BionIT

Hi @raintygao, is this PR targeting 2.15 or 2.16?

Hi @BionIT , there will be some new UX design updates in this part, we convert this PR to draft for now.

raintygao avatar Jun 05 '24 09:06 raintygao

@raintygao I guess we can close this PR now?

ruanyl avatar Aug 12 '24 09:08 ruanyl

@raintygao I guess we can close this PR now?

Sure. Closed.

raintygao avatar Aug 12 '24 09:08 raintygao