OpenSearch-Dashboards
OpenSearch-Dashboards copied to clipboard
[MDS] Expose common url key for consumers
Description
This PR adds a common URL key for plugins/other consumers to consume.
Issues Resolved
Closes #6534
Screenshot
Testing the changes
Changelog
- fix: [MDS] Expose common url key to query for datasource
Check List
- [ ] All tests pass
- [ ]
yarn test:jest - [ ]
yarn test:jest_integration
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update CHANGELOG.md
- [ ] Commits are signed per the DCO using --signoff
❌ Empty Changelog Section
The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.44%. Comparing base (
75e6087) to head (608dd9a). Report is 124 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6602 +/- ##
==========================================
- Coverage 67.44% 67.44% -0.01%
==========================================
Files 3442 3442
Lines 67804 67805 +1
Branches 11025 11025
==========================================
- Hits 45730 45729 -1
- Misses 19408 19409 +1
- Partials 2666 2667 +1
| Flag | Coverage Δ | |
|---|---|---|
| Linux_1 | 33.09% <ø> (ø) |
|
| Linux_2 | 55.06% <ø> (ø) |
|
| Linux_3 | 45.21% <100.00%> (-0.01%) |
:arrow_down: |
| Linux_4 | 34.87% <100.00%> (+<0.01%) |
:arrow_up: |
| Windows_1 | 33.11% <ø> (ø) |
|
| Windows_2 | 55.01% <ø> (ø) |
|
| Windows_3 | 45.23% <100.00%> (+<0.01%) |
:arrow_up: |
| Windows_4 | 34.87% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can we hold off on this one and include it in 2.15, given that we're close to the 2.14 code freeze date? It might look like a small change, but it requires the plugin team to go through the development cycle again to adopt this change
Can we hold off on this one and include it in 2.15, given that we're close to the 2.14 code freeze date? It might look like a small change, but it requires the plugin team to go through the development cycle again to adopt this change
Acknowledged. Moved to 2.15
@huyaboo Is this still being targeted for 2.16.
@huyaboo Is this still being targeted for 2.16.
@LDrago27 No this is pushed back to 2.17
Hey @huyaboo, is this still targeted for 2.17?