OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[Draft][OE] Adds TS check workflow

Open ashwin-pc opened this issue 1 year ago • 1 comments

Description

Adds a TS check to the github workflow. This causes increases in TS Errors to be flagged and fail the CI

Issues Resolved

Screenshot

Testing the changes

The Typescript Check in the PR's CI should pass

Changelog

  • skip

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

ashwin-pc avatar Apr 22 '24 10:04 ashwin-pc

@SuZhou-Joe @ruanyl , thanks for reviewing this. This PR isnt ready for review yet, but i cant put it in draft cause the CI wont run if it is, and i need it to test the github workflow. Will let you know once this is ready :)

ashwin-pc avatar May 02 '24 16:05 ashwin-pc

Hi @ashwin-pc , is this PR targeting 2.15 or 2.16?

BionIT avatar Jun 05 '24 03:06 BionIT

@BionIT This isnt targetting any specific release. This is an OE change that when i have the bandwith i'll try to get back to

ashwin-pc avatar Jun 12 '24 22:06 ashwin-pc