OpenSearch-Dashboards
OpenSearch-Dashboards copied to clipboard
[Multiple DataSource] TypeError Fix
Description
Draft pr to fix type error and still in progress, don't merge now
Issues Resolved
#3026
Screenshot
Testing the changes
Check List
- [ ] All tests pass
- [ ]
yarn test:jest - [ ]
yarn test:jest_integration
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update CHANGELOG.md
- [ ] Commits are signed per the DCO using --signoff
Codecov Report
Attention: Patch coverage is 31.57895% with 26 lines in your changes missing coverage. Please review.
Project coverage is 67.71%. Comparing base (
d2d410b) to head (755ec42). Report is 97 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6356 +/- ##
===========================================
+ Coverage 32.93% 67.71% +34.77%
===========================================
Files 2260 3403 +1143
Lines 45769 66621 +20852
Branches 7200 10839 +3639
===========================================
+ Hits 15075 45113 +30038
+ Misses 29984 18856 -11128
- Partials 710 2652 +1942
| Flag | Coverage Δ | |
|---|---|---|
| Linux_1 | 33.05% <ø> (+0.11%) |
:arrow_up: |
| Linux_2 | 55.60% <ø> (?) |
|
| Linux_3 | 45.17% <31.57%> (?) |
|
| Linux_4 | 34.92% <ø> (?) |
|
| Windows_1 | 33.10% <ø> (?) |
|
| Windows_2 | 55.57% <ø> (?) |
|
| Windows_3 | 45.19% <31.57%> (?) |
|
| Windows_4 | 34.92% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@xinruiba I just removed 2.15 tag for this PR, and please feel free to correct if not expected
moved 2.16 tag