OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[OE] Stabilize and document saved objects API

Open kavilla opened this issue 10 months ago • 4 comments

Is your feature request related to a problem? Please describe.

We have a lot of issues with the saved objects API even though it's a fundamental item of OpenSearch Dashboards. The API is being used more and more even though it technically never was made a production feature.

Current open issues related to the saved objects API:

  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3023
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3195
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2132
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/1723
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/1700
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/1464
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/1360
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/910
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/987
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/1526
  • https://github.com/opensearch-project/OpenSearch-Dashboards/issues/1647
  • https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5946
    • this was merged but this only addresses the side effect but in reality users should not be able to upload identically saved objects

Describe the solution you'd like

  • Stabilize saved objects API
  • Address gaps and provide more validation with in the API
  • More testing
  • Explicit documentation
    • Perhaps adding writing an SDK so developers can utilize the saved objects API

Describe alternatives you've considered

n/a

Additional context

n/a

kavilla avatar Apr 02 '24 07:04 kavilla

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/6340

Another relevant item for this list 😄

BlaiseSaunders avatar Apr 04 '24 00:04 BlaiseSaunders

@Flyingliuhub @bandinib-amzn @BionIT @CCongWang this is critical, let's see how could we help.

seraphjiang avatar Apr 13 '24 06:04 seraphjiang

Adding onto this: the saved objects API is a critical dependency for Integrations and we regularly are exporting/tweaking/reimporting them. This is made much more difficult by the lack of documentation on how different objects are serialized and their behavior when values are changed -- most of what our team knows about this has been found through trial-and-error. We maintain exported dashboards, visualizations, and searches as code and have tools that auto-generate saved objects or parse them for nicer debugging info.

All that to say, +1 for stabilizing the APIs and getting traction on these issues :)

Swiddis avatar Apr 16 '24 22:04 Swiddis

https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4695

kavilla avatar Apr 30 '24 22:04 kavilla

Any progress on this? We could consider enhancing the existing docs and promoting the described endpoint to stable, I'm not sure what breaking changes are upcoming but since April the amount of features depending on this endpoint has only been growing.

Swiddis avatar Aug 22 '24 17:08 Swiddis