filter out data source object when export

[yujin-emma]

Description

Issues Resolved

Screenshot

Testing the changes

Check List

• [ ] All tests pass
  • [ ] yarn test:jest
  • [ ] yarn test:jest_integration
• [ ] New functionality includes testing.
• [ ] New functionality has been documented.
• [ ] Update CHANGELOG.md
• [ ] Commits are signed per the DCO using --signoff

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.15%. Comparing base (45096bb) to head (e3a767e). Report is 147 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6124      +/-   ##
==========================================
- Coverage   67.15%   67.15%   -0.01%     
==========================================
  Files        3326     3326              
  Lines       64400    64401       +1     
  Branches    10361    10361              
==========================================
- Hits        43251    43250       -1     
- Misses      18619    18620       +1     
- Partials     2530     2531       +1     

Flag	Coverage Δ
Linux_1	31.73% <0.00%> (-0.01%)	:arrow_down:
Linux_2	55.23% <100.00%> (+<0.01%)	:arrow_up:
Linux_3	44.75% <0.00%> (-0.01%)	:arrow_down:
Linux_4	35.08% <0.00%> (-0.01%)	:arrow_down:
Windows_1	31.75% <0.00%> (-0.01%)	:arrow_down:
Windows_2	55.20% <100.00%> (+<0.01%)	:arrow_up:
Windows_3	44.75% <0.00%> (-0.01%)	:arrow_down:
Windows_4	35.08% <0.00%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[BionIT]

Can we add context for this PR as well as what manual tests have been done?

[SuZhou-Joe]

Maybe it is not a good time to ask such question but I'm thinking why don't we make data-source as a hidden type? Hidden type won't be export as allowed types in saved objects management and can not be performed CRUD operations on by a normal saved objects client. That meets what data source needs I suppose.

[yujin-emma]

Maybe it is not a good time to ask such question but I'm thinking why don't we make data-source as a hidden type? Hidden type won't be export as allowed types in saved objects management and can not be performed CRUD operations on by a normal saved objects client. That meets what data source needs I suppose.

We still need to list the data source object, but since it contains the auth information, we cannot import/export, more discussion is here

[Hailong-am]

If an index pattern depends on datasource, and we don't export datasource will that break the reference? If yes, the user experience is same, all dashboards/visualization will be broken.

we might need remove the reference in index pattern as well when export.

[kavilla]

@yujin-emma will remove the 2.14 label as this in draft still. And have added the 2.15 label or if it needs to be closed feel free to do so.

[BionIT]

@yujin-emma Is this PR still being worked on, are we plan to fix in 2.15?

[yujin-emma]

Close this pull request since we do not plan to work on filter data source object when export, we are going to stop importing data source objects, and the code change already merged in main : https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6395