OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

New Home Page

Open abbyhu2000 opened this issue 11 months ago • 2 comments

Description

This PR is built upon the original home page PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5613 authored by @BSFishy

Added a new commit on replacing the yml config with advanced setting.

Issues Resolved

resolves #6056

Screenshot

Screenshot 2024-03-07 at 11 42 16 AM

Testing the changes

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [ ] Commits are signed per the DCO using --signoff

abbyhu2000 avatar Mar 07 '24 19:03 abbyhu2000

Currently i placed the advanced setting under general section. Do we need to change any wording here? @kgcreative @ashwin-pc

abbyhu2000 avatar Mar 07 '24 19:03 abbyhu2000

Codecov Report

Attention: Patch coverage is 59.82906% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 67.21%. Comparing base (8c4f49a) to head (f2f1146). Report is 1 commits behind head on main.

Files Patch % Lines
.../home/public/services/section_type/section_type.ts 70.00% 12 Missing and 3 partials :warning:
...on/components/homepage/sections/work_with_data.tsx 25.00% 9 Missing :warning:
...tion/components/homepage/sections/learn_basics.tsx 30.00% 7 Missing :warning:
src/plugins/home/public/plugin.ts 50.00% 4 Missing :warning:
.../public/services/section_type/section_type.mock.ts 63.63% 4 Missing :warning:
src/plugins/home/server/saved_objects/homepage.ts 25.00% 3 Missing :warning:
...application/components/homepage/sections/utils.tsx 33.33% 2 Missing :warning:
...ved_objects_management/public/register_services.ts 0.00% 1 Missing and 1 partial :warning:
...gins/home/public/saved_homepage/_saved_homepage.ts 87.50% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6065      +/-   ##
==========================================
- Coverage   67.22%   67.21%   -0.01%     
==========================================
  Files        3333     3342       +9     
  Lines       64565    64681     +116     
  Branches    10391    10408      +17     
==========================================
+ Hits        43404    43476      +72     
- Misses      18628    18662      +34     
- Partials     2533     2543      +10     
Flag Coverage Δ
Linux_1 31.64% <8.24%> (-0.06%) :arrow_down:
Linux_2 55.45% <ø> (ø)
Linux_3 44.55% <8.51%> (-0.11%) :arrow_down:
Linux_4 35.09% <59.82%> (+0.10%) :arrow_up:
Windows_1 31.67% <8.24%> (-0.06%) :arrow_down:
Windows_2 55.41% <ø> (ø)
Windows_3 44.57% <8.51%> (-0.11%) :arrow_down:
Windows_4 35.09% <59.82%> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 07 '24 19:03 codecov[bot]

I would recommend using the changelog from main and adding the entry. The one here has too many changes and almost all are undesired.

AMoo-Miki avatar Mar 13 '24 23:03 AMoo-Miki

Cc: @lauralexis

kgcreative avatar Mar 14 '24 03:03 kgcreative

Should add some fallback mechanism if getting the new home page failed. https://github.com/opensearch-project/OpenSearch-Dashboards/issues/6146

abbyhu2000 avatar Mar 14 '24 19:03 abbyhu2000

Thanks for the great work @BSFishy @abbyhu2000

ananzh avatar Mar 15 '24 23:03 ananzh