OpenSearch-Dashboards
OpenSearch-Dashboards copied to clipboard
New Home Page
Description
This PR is built upon the original home page PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5613 authored by @BSFishy
Added a new commit on replacing the yml config with advanced setting.
Issues Resolved
resolves #6056
Screenshot
Testing the changes
Check List
- [ ] All tests pass
- [ ]
yarn test:jest
- [ ]
yarn test:jest_integration
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update CHANGELOG.md
- [ ] Commits are signed per the DCO using --signoff
Currently i placed the advanced setting under general section. Do we need to change any wording here? @kgcreative @ashwin-pc
Codecov Report
Attention: Patch coverage is 59.82906%
with 47 lines
in your changes are missing coverage. Please review.
Project coverage is 67.21%. Comparing base (
8c4f49a
) to head (f2f1146
). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6065 +/- ##
==========================================
- Coverage 67.22% 67.21% -0.01%
==========================================
Files 3333 3342 +9
Lines 64565 64681 +116
Branches 10391 10408 +17
==========================================
+ Hits 43404 43476 +72
- Misses 18628 18662 +34
- Partials 2533 2543 +10
Flag | Coverage Δ | |
---|---|---|
Linux_1 | 31.64% <8.24%> (-0.06%) |
:arrow_down: |
Linux_2 | 55.45% <ø> (ø) |
|
Linux_3 | 44.55% <8.51%> (-0.11%) |
:arrow_down: |
Linux_4 | 35.09% <59.82%> (+0.10%) |
:arrow_up: |
Windows_1 | 31.67% <8.24%> (-0.06%) |
:arrow_down: |
Windows_2 | 55.41% <ø> (ø) |
|
Windows_3 | 44.57% <8.51%> (-0.11%) |
:arrow_down: |
Windows_4 | 35.09% <59.82%> (+0.10%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I would recommend using the changelog from main
and adding the entry. The one here has too many changes and almost all are undesired.
Cc: @lauralexis
Should add some fallback mechanism if getting the new home page failed. https://github.com/opensearch-project/OpenSearch-Dashboards/issues/6146
Thanks for the great work @BSFishy @abbyhu2000