OpenSearch-Dashboards
OpenSearch-Dashboards copied to clipboard
Remove empty space when resize datagrid table in Discover and Allow saving column width in both Discover and Dashboards Embeddable
Description
- Fixes the column resize issue observed in https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5671, which shows empty space on the right when drag the column.
- Allow saved column width which is a feature request in https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5726.
- It also allows dashboard embeddable to save the datagrid table width adjustment.
Issues Resolved
https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5671 https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5726
Screenshot
https://github.com/opensearch-project/OpenSearch-Dashboards/assets/79961084/190d464b-b401-489d-871d-599cdb5eb10b
Testing the changes
Check List
- [ ] All tests pass
- [ ]
yarn test:jest - [ ]
yarn test:jest_integration
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update CHANGELOG.md
- [ ] Commits are signed per the DCO using --signoff
Codecov Report
Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.
Project coverage is 67.34%. Comparing base (
902e216) to head (6a22b71). Report is 113 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #5883 +/- ##
==========================================
- Coverage 67.34% 67.34% -0.01%
==========================================
Files 3352 3352
Lines 65080 65088 +8
Branches 10485 10488 +3
==========================================
+ Hits 43829 43834 +5
- Misses 18699 18701 +2
- Partials 2552 2553 +1
| Flag | Coverage Δ | |
|---|---|---|
| Linux_1 | 31.82% <0.00%> (-0.01%) |
:arrow_down: |
| Linux_2 | 55.57% <ø> (ø) |
|
| Linux_3 | 44.75% <66.66%> (+<0.01%) |
:arrow_up: |
| Linux_4 | 35.03% <ø> (ø) |
|
| Windows_1 | 31.84% <0.00%> (-0.01%) |
:arrow_down: |
| Windows_2 | 55.53% <ø> (ø) |
|
| Windows_3 | 44.75% <66.66%> (+<0.01%) |
:arrow_up: |
| Windows_4 | 35.03% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We think add this will slow the column resize and might choose a different way to resolve the issue. As synced up with @ashwin-pc, we will put it in 2.14 release.
@ananzh will remove the 2.14 label as this in draft still. And have added the 2.15 label or if it needs to be closed feel free to do so.
Hi @ananzh , is this PR targeting 2.15?