OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[BUG] Can't view surrounding documents when there's a "+" in the id

Open AB027PS opened this issue 1 year ago • 7 comments

Describe the bug

When I go to discover, find some documents using an index pattern and then try to view surrounding documents of one of them, I get an error that says "Unable to fetch anchor document". This only happens to when the _id of the document contains a plus sign. If I substitute %2B for + in the URL in the new window, it works.

To Reproduce Steps to reproduce the behavior:

  1. Create an index and several documents for it whose _id will contain a plus sign.
  2. Create an index pattern for your index.
  3. Go to discover, select your index pattern and find a document.
  4. Click on the magnifying glass sign next to a document and the view surrounding documents.

Expected behavior A new window will open with surrounding documents

OpenSearch Version 2.11 Docker image 2.11.1

Dashboards Version 2.11 Docker image 2.11.1

Plugins

N/A

Screenshots

image image

Host/Environment (please complete the following information):

  • OS: Linux
  • Browser and version 120.0.6099.218 (Official Build) (64-bit)

Additional context

Add any other context about the problem here.

AB027PS avatar Jan 19 '24 12:01 AB027PS

@abbyhu2000 can you check if this is being addressed already in 2.12 or still need to be fixed by 2.13. Check if regression issue prior to new Discover. If it's existing issue (prior to new Discover) then it might be worth considering if it should be backported and released.

kavilla avatar Feb 20 '24 18:02 kavilla

This could be an issue with encoding and maybe will have to do a patch to fix this.

kavilla avatar Feb 20 '24 18:02 kavilla

Follow up: Do we need better documentation on characters that need to be supported within OpenSearch and OpenSearch Dashboards. Can I insert 我是

kavilla avatar Feb 20 '24 18:02 kavilla

just confirmed: this is a regression of release 2.11 discover. Legacy discover in 2.10 does not have this bug. Should we target to fix this? @kavilla @ananzh @ashwin-pc

The following video is from 2.10 branch:

https://github.com/opensearch-project/OpenSearch-Dashboards/assets/43937633/7cba6e38-54a7-43c0-b67a-732ffa688ac1

abbyhu2000 avatar Feb 20 '24 23:02 abbyhu2000

Should fix this in 2.13

abbyhu2000 avatar Feb 27 '24 18:02 abbyhu2000

@AB027PS This should be fixed in the 2.12 release https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5776. Can you verify?

ashwin-pc avatar Mar 05 '24 23:03 ashwin-pc

Hi @ashwin-pc I tried it with version 2.12 in Docker and the bug is still there.

AB027PS avatar Mar 06 '24 09:03 AB027PS