OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[MD] Add experimental callout for index pattern section

Open yibow98 opened this issue 3 years ago • 4 comments

Signed-off-by: Yibo Wang [email protected]

Description

This PR fixes several issues from https://github.com/opensearch-project/ux/issues/16

Index pattern listing page: Screen Shot 2022-10-05 at 8 07 54 PM

Index pattern create page-step one: Screen Shot 2022-10-05 at 8 05 54 PM Index pattern create page-step two: Screen Shot 2022-10-05 at 8 06 13 PM Index pattern create page-step three: Screen Shot 2022-10-05 at 8 06 38 PM

Issues Resolved

https://github.com/opensearch-project/ux/issues/37 https://github.com/opensearch-project/ux/issues/39 https://github.com/opensearch-project/ux/issues/41 https://github.com/opensearch-project/ux/issues/43

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
    • [ ] yarn test:jest_integration
    • [ ] yarn test:ftr
  • [x] New functionality includes testing.
  • [x] New functionality has been documented.
  • [x] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

yibow98 avatar Oct 06 '22 01:10 yibow98

could we add screenshot?

seraphjiang avatar Oct 06 '22 02:10 seraphjiang

could we add screenshot?

Added screenshots for all pages.

yibow98 avatar Oct 06 '22 03:10 yibow98

Thanks @yibow98, looks like the snapshots need to be updated for tests since they are failing. Which can be done with yarn test:jest -u.

kavilla avatar Oct 06 '22 11:10 kavilla

Thanks @yibow98, looks like the snapshots need to be updated for tests since they are failing. Which can be done with yarn test:jest -u.

Thanks @kavilla ! I updated snapshots accordingly.

yibow98 avatar Oct 06 '22 19:10 yibow98

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2523-to-2.x.

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2523-to-2.x.

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2523-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 777774910d00587ccb28f9a59407b5059e8803d5
# Push it to GitHub
git push --set-upstream origin backport/backport-2523-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2523-to-2.x.