OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

[MD] UX refactor for datasource create page

Open yibow98 opened this issue 3 years ago • 3 comments
trafficstars

Signed-off-by: Yibo Wang [email protected]

Description

UX refactor for datasource create page Screen Shot 2022-10-04 at 1 31 53 PM

Issues Resolved

https://github.com/opensearch-project/ux/issues/19 https://github.com/opensearch-project/ux/issues/23 https://github.com/opensearch-project/ux/issues/24 https://github.com/opensearch-project/ux/issues/25 https://github.com/opensearch-project/ux/issues/26 https://github.com/opensearch-project/ux/issues/29 #2434 #2439

Check List

  • [x] All tests pass
    • [x] yarn test:jest
    • [ ] yarn test:jest_integration
    • [ ] yarn test:ftr
  • [x] New functionality includes testing.
  • [x] New functionality has been documented.
  • [x] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

yibow98 avatar Oct 04 '22 20:10 yibow98

Do we need to update the snapshot as well?

noCharger avatar Oct 04 '22 21:10 noCharger

Codecov Report

Merging #2501 (858ea59) into main (7777749) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2501   +/-   ##
=======================================
  Coverage   66.73%   66.73%           
=======================================
  Files        3203     3204    +1     
  Lines       60978    60988   +10     
  Branches     9274     9274           
=======================================
+ Hits        40692    40702   +10     
  Misses      18067    18067           
  Partials     2219     2219           
Impacted Files Coverage Δ
src/core/public/doc_links/doc_links_service.ts 100.00% <ø> (ø)
...components/create_form/create_data_source_form.tsx 83.60% <100.00%> (+0.27%) :arrow_up:
...te_data_source_wizard/components/header/header.tsx 100.00% <100.00%> (ø)
...ent/public/components/text_content/text_content.ts 100.00% <100.00%> (ø)
...nent/experimental_callout/experimental_callout.tsx 100.00% <100.00%> (ø)
...ared/static/forms/hook_form_lib/hooks/use_field.ts 65.70% <0.00%> (-0.97%) :arrow_down:
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) :arrow_down:
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) :arrow_up:
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 07 '22 00:10 codecov-commenter

could we convert this to official PR instead create new one?

what are merge conflict? could we fix it?

@zhongnansu @kristenTian could one of you help?

seraphjiang avatar Oct 07 '22 16:10 seraphjiang

@yibow98 and I discussed offline and agreed that this and other unit tests will be addressed in a follow up PR. @yibow98 please link this PR to that so that it is easier to discover those changes in future.

Thanks @ashwin-pc for giving me some constructive feedback and suggestions. Will address all unit test issues in my next PR and I will link this PR as a reference~

yibow98 avatar Oct 11 '22 00:10 yibow98

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2501-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9b56ff50327154cd531fcd4479ab2fc3798cf86b
# Push it to GitHub
git push --set-upstream origin backport/backport-2501-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2501-to-2.x.