OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

[Improvement] remove `@ts-ignore` from plugin builder update version file

Open kavilla opened this issue 2 years ago • 2 comments

@ts-ignore was included here.

We should be able remove and backport to ensure modules imported from Node are available.

kavilla avatar Oct 03 '22 21:10 kavilla

@kavilla I would like to work on this issue if it is a part of the Hacktoberfest 2022. Could you provide some insights on how to test it and i can do the rest

amoghrajesh avatar Oct 04 '22 09:10 amoghrajesh

Hi @amoghrajesh , thanks for volunteering!

  1. Delete the @ts-ignore line
  2. Verify that the project still lints successfully with yarn lint

That should be about it!

joshuarrrr avatar Oct 04 '22 20:10 joshuarrrr

Hey is this issue fixed? If not I'd like to try

Joymfl avatar Oct 18 '22 21:10 Joymfl

@Joymfl it has not been fixed - feel free to make a PR!

joshuarrrr avatar Oct 18 '22 23:10 joshuarrrr

@joshuarrrr Awesome! Yarn is acting up for some reason. Once I'm done wrestling with yarn I'm gonna quickly make a PR

Joymfl avatar Oct 19 '22 17:10 Joymfl

@joshuarrrr is it still open?

vimalMK avatar Oct 27 '22 22:10 vimalMK

@Joymfl Are you still planning to submit a PR? If not let @vimalMK know so they can pick it up.

joshuarrrr avatar Oct 28 '22 01:10 joshuarrrr

Hey, I am still working on it. But if you think it's taking long, I don't mind if you hand it over :D

Joymfl avatar Oct 28 '22 02:10 Joymfl

@Joymfl If you are working on it , Please carry on :).

vimalMK avatar Oct 28 '22 18:10 vimalMK