OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

[Chore] Refactor and improve Discover field summaries

Open joshuarrrr opened this issue 3 years ago • 2 comments

  • Convert to typescript
  • Fix types
  • Add tests

Description

Typescript cleanup is a prerequisite to #950

Issues Resolved

N/A

Check List

  • [x] New functionality includes testing.
    • [x] All tests pass
      • [x] yarn test:jest
      • [ ] yarn test:jest_integration
      • [ ] yarn test:ftr
  • [ ] New functionality has been documented.
  • [x] Commits are signed per the DCO using --signoff

joshuarrrr avatar Sep 20 '22 18:09 joshuarrrr

converting to draft until I have time to debug the functional test (I've already manually verified that the the filter controls in field summaries still work with scripted fields, so it's likely something in the test case or test IDs, not in the feature).

joshuarrrr avatar Sep 28 '22 19:09 joshuarrrr

Based on our latests discussions, these tests should move to https://github.com/opensearch-project/opensearch-dashboards-functional-test. Lets move it there and deprecate the failing tests.

ashwin-pc avatar Sep 29 '22 19:09 ashwin-pc