open-scd icon indicating copy to clipboard operation
open-scd copied to clipboard

Published 20 hours ago • verified publisher icon openscd

feat: Added sonarcloud Github Action

Open pascalwilbrink opened this issue 1 year ago • 5 comments

feat: Added sonarcloud Github Action fixes: #1242

pascalwilbrink avatar Apr 26 '23 10:04 pascalwilbrink

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jun 22 '23 02:06 sonarqubecloud[bot]

@pascalwilbrink let's apply the same principle here of splitting the process into an unprivileged build workflow and a subsequent one triggered by workflow_run to have access to the Sonarcloud secret and analyze forked PRs

juancho0202 avatar Jun 22 '23 02:06 juancho0202

Is this PR still relevant?

trusz avatar Aug 22 '23 09:08 trusz

It is weird that sonarcloud did not find anything. We have to check the configs.

trusz avatar Sep 06 '23 13:09 trusz

It is weird that sonarcloud did not find anything. We have to check the configs.

@trusz it is weird because if you navigate to their analysis of the main branch there are 45 bugs detailed in there: https://sonarcloud.io/project/issues?resolved=false&id=openscd_open-scd

juancho0202 avatar Sep 11 '23 07:09 juancho0202

The SonarCloud projects does not exist anymore. I will close this PR, but we can reopen it again if we want to proceed with SonarCloud

trusz avatar Jul 18 '24 08:07 trusz