open-scd icon indicating copy to clipboard operation
open-scd copied to clipboard

Change appendChild / prependChild to createActions

Open pascalwilbrink opened this issue 1 year ago • 4 comments

In order to make maximum use of the Action API, we should change all the appendChild and prependChild occurrences to createActions. This is used in OpenSCD and CoMPAS.

This will make sure that the new element will be in the right place. If a new XSD schema rolls out, we only have to change 1 function, the foundation.

pascalwilbrink avatar Mar 31 '23 09:03 pascalwilbrink

usages:

connectedAp.ts subnetwork.ts editors/subscription/foundation.ts menu/virtualtemplateied/foundation.ts wizards/address.ts wizards/bda.ts wizards/clientln.ts wizards/conductingequipment.ts wizards/da.ts wizards/reportcontrol.ts wizards/sampledvaluedcontrolts wizards/voltagelevel.ts wizards/subNetwork.ts

pascalwilbrink avatar Apr 03 '23 07:04 pascalwilbrink

@JakobVogelsang will look into the current usage and determine if change is needed.

Sander3003 avatar Apr 03 '23 07:04 Sander3003

It is a bug when undo will result in a missing element.

Sander3003 avatar Apr 03 '23 07:04 Sander3003

Hello there,

Thank you for opening this issue! We appreciate your interest in our project. However, it seems that this issue hasn't had any activity for a while. To ensure that our issue tracker remains organized and efficient, we occasionally review and address stale issues.

If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better. Feel free to continue the conversation here.

If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later.

Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve. Thank you for being part of this journey!

github-actions[bot] avatar Sep 03 '23 19:09 github-actions[bot]

Fixed by the new action API

Sander3003 avatar Oct 09 '24 12:10 Sander3003