Add pitch argument to roof

[MethylBromide]

Is your feature request related to a problem? Please describe. About 80% of the time, when I use roof, I then need to scale the result because I didn't want a 45 degree slope. It's not immediately obvious what scaling factor to use to get a desired slope angle. It's a PITA for each developer to have to figure out that formula and keep track of it.

Describe the solution you'd like Could we please have a pitch argument, default value 45, to have the function do that math? It's just to scale Z by tan of the desired angle, but again, not obvious to the typical user.

Describe alternatives you've considered Wrote my own roof module to keep track of the formula for this.

[kintel]

Note: roof() has fallen out of maintenance and needs significant love to survive: https://github.com/openscad/openscad/labels/Feature%3A%20Roof

[gsohler]

I think that Roof IS still Working and i would regret seeing it Leave. I need IT for my Greensand Molds.

Marius Kintel @.***> schrieb am Fr., 4. Okt. 2024, 16:46:

Note: roof() has fallen out of maintenance and needs significant love to survive: Feature: Roof https://github.com/openscad/openscad/labels/Feature%3A%20Roof

— Reply to this email directly, view it on GitHub https://github.com/openscad/openscad/issues/5354#issuecomment-2393881053, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCO4MS54C5IYKLQL7VNORDZZ2S3RAVCNFSM6AAAAABPL5DYNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJTHA4DCMBVGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[MethylBromide]

Please don't let it fade away. It's super useful and I don't know an alternative.

[kintel]

Not planning to kill it, but it desperately needs an owner to maintain, finalize and get out of experimental mode

[gsohler]

Hi @kintel, I could imagine to look after roof, even though I do not !exactly know, how it is working, especially not the 2nd more option. Yes, I understand that its in experiemental mode, and it has always worked for me like expected.

So maybe you could describe some microstepping tasks, what actually needs to be done ?

On Fri, Dec 6, 2024 at 4:58 AM Marius Kintel @.***> wrote:

Not planning to kill it, but it desperately needs an owner to maintain, finalize and get out of experimental mode

— Reply to this email directly, view it on GitHub https://github.com/openscad/openscad/issues/5354#issuecomment-2522070203, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCO4MU3YNF5JNGX5BU7LPD2EEOHNAVCNFSM6AAAAABPL5DYNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRSGA3TAMRQGM . You are receiving this because you commented.Message ID: @.***>

[kintel]

@gsohler This isn't really a prescriptive task, it's more about taking ownership over the feature. Some things that needs care:

• Own the API, and move it towards a long-term stable API, making changes as needed.
• Build consensus in the user- and dev-community what the API should look like and how it interacts with other plans and ideas.
• Manage the issues tagged a roof issues: https://github.com/openscad/openscad/labels/Feature%3A%20Roof
• Make sure the test cases cover all features and corner cases
• Provide documentation as needed
• Recruit help with the above tasks as needed

Out of all of these things, building consensus tends to be the hardest one, since once we publish this API, we're committed to support it forever, so the quality bar can be significantly higher than for other types of features.

Not all of these needs to be fixed to move it out of experimental, it's mostly about the API being stable enough, bugs being under control, and a dev-community consensus that it's a supportable feature so that bugs can be fixed as needed etc.

[gsohler]

@kintel,

Getting things working is one thing, but I am sorry to say, that building consensus and planning future is not part of my strenghts.