MCAD
MCAD copied to clipboard
openscad
lathe change gears
I would like to add a feature for making involute change gears which are used on lathes, which are similar to the gear function in this file, but generally are symmetric about the plane of rotation instead of having the hub offset, and generally have spokes rather than a flat disk or disk with circular holes. I think many will find this useful. I have the code working, and could simply add the features into the existing gear function with the addition of some spoke parameters and a symmetric flag. Otherwise I could have a separate function altogether. I am not sure who is maintaining the involute gear library and want to tread lightly as I go since I am new to this environment. If anyone has advise, please respond.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Integrating those features via new opt-in parameters that sounds like a good approach. Could you submit the PR against the dev branch please? The gear module has had some changes since the master branch and that's where development happens these days.
the dev branch involute_gears seams quite broken, especially the internal gears. do I fix the involute problems first on a separate branch? I am comfortable with any changes in openscad, but less familiar with this branch/branch/pullrequest github process.
Submitting a pull request against the dev branch is similar to submitting against the master branch, just that you need to change the base branch to dev like so:
If it's too much trouble, you can also submit your PR to master as-is, and I'll just merge it into master and port the changes over to dev at a later date
Let me look at the state of the main branch. I will get this in soon, but I am busy at work this week.
I fixed several issues including fixing the test case, fixing the rack, and adding the spoked gears, all based on the Master. I created a pull request.